Re: question about freezed panes

On Thu, Oct 23, 2003 at 11:06:19AM +0200, Parrenin Fr?d?ric wrote:

I have tested your patch and I don't see any problem at first glance.
However, your patch doesn't address the problem with <enter> and <Tab>
keys.  Hitting <enter> or <tab> in a cell in the upper pane leads
to an autoscroll.
that is known.  That requires another tiny patch.
Index: src/selection.c
RCS file: /cvs/gnome/gnumeric/src/selection.c,v
retrieving revision 1.163
diff -u -w -r1.163 selection.c
--- src/selection.c     15 Oct 2003 13:42:56 -0000      1.163
+++ src/selection.c     23 Oct 2003 12:44:14 -0000
@@ -1207,7 +1207,7 @@
                                          destination.col, destination.row,
                                          destination.col, destination.row);
                        sv_make_cell_visible (sv, sv->edit_pos.col,
-                                             sv->edit_pos.row, TRUE);
+                                             sv->edit_pos.row, FALSE);
@@ -1238,7 +1238,7 @@
        sv_set_edit_pos (sv, &destination);
-       sv_make_cell_visible (sv, destination.col, destination.row, TRUE);
+       sv_make_cell_visible (sv, destination.col, destination.row, FALSE);
 #include <goffice/graph/gog-series.h>

Also, crossing the boundary of the upper pane with the cursor leads to
an autoscroll, e.g.:
-select A10
-freeze panes
-page down several times
-select A9
-hit the bottom arrow
=> lower pane has autoscrolled
I think it is not necessary.

I disagree on that one.  Think aboutthe situation when you button
down on A9 then drag downward.  That should definitely scroll the
lower panes (note: I use 'autoscroll' to mean scrolling due to a
drag outside the sheet).  Hitting down arrow at the boundary is
debatable.  I don't see the intervening elements as hidden, just
scrolled.  So it seems reasonable to assume a user wants to go to
the next row rather than the next visible row.  It would be fairly
easy to make this a preference, but we're starting to get too many
of those already.

Thanks for testing things

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]