Re: BIFF loader source

Hi Nick,

On Fri, 2002-01-11 at 16:13, Nick Lamb wrote:

        It's great that you've put the work in to do this, and it's a really
neat feature - wait for it: But:

        a) The ms-biff.h of the current excel plugin provides a
           relatively abstract stream API already, that should easily
           cope with a native biff stream rather than one coming from
           an ole2 file.

        b) Given the above, it appears that you have cut and pasted, a
           truly vast chunk of code, and then made various changes,
           often switching on the biff version number (which was
           intended to allow this all to be written as a single chunk
           without code duplication in the first place).

        So - really, the changes need to be re-integrated into the main excel
plugin, which should be fairly trivial. Then another ms-excel-stream
implementation needs to be written. Possibly the easiest way to do this
is by writing a MsOleStream impl. for a plain biff file - since it's all
virtualized at that level anyway.

        Does that make sense ?



 mmeeks gnu org  <><, Pseudo Engineer, itinerant idiot

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]