Re: [PATCH] some performance improvements
- From: Rodrigo Moya <rodrigo novell com>
- To: Lorenzo Colitti <lorenzo colitti com>
- Cc: gnomecc-list gnome org
- Subject: Re: [PATCH] some performance improvements
- Date: Mon, 17 Oct 2005 12:41:05 +0200
On Sun, 2005-10-16 at 06:03 +0200, Lorenzo Colitti wrote:
> Rodrigo Moya wrote:
> > hmm, which leak are you fixing? The GConfClient? My code:
> >
> > + client = gconf_client_get_default ();
> > show_error = gconf_client_get_bool (client, SHOW_STARTUP_ERRORS_KEY, NULL);
> > + g_object_unref (client);
> >
> > the reason I did not ref it in gnome_settings_screensaver_load is that
> > my next patch changes all the code to use a common GConfClient, so no
> > need for _ref/_unref.
>
> Ok. I changed it because the first patch you sent had:
>
yeah, right, that was the first patch I sent, before you told me about
the GConfClient problem.
--
Rodrigo Moya <rodrigo novell com>
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]