Re: [PATCH] some performance improvements

[Lorenzo Colitti <lorenzo colitti com>]

Rodrigo Moya wrote:
> hmm, which leak are you fixing? The GConfClient? My code:
>
> +       client = gconf_client_get_default ();
>         show_error = gconf_client_get_bool (client, SHOW_STARTUP_ERRORS_KEY, NULL);
> +       g_object_unref (client);
>
> the reason I did not ref it in gnome_settings_screensaver_load is that
> my next patch changes all the code to use a common GConfClient, so no
> need for _ref/_unref. 

Ok. I changed it because the first patch you sent had:

> +       GConfClient *client = user_data;

and then didn't unref it. I used the wrapper function because I thought 
it might be a good idea to avoid another gconf_client_get_default() 
call, since markmc said it is expensive. That said, the code you 
committed looks fine to me.

Thanks for putting this in!


Ciao,
Lorenzo

--
Lorenzo Colitti                          http://www.colitti.com/lorenzo/