Re: [PATCH] some performance improvements

[Rodrigo Moya <rodrigo novell com>]

On Sat, 2005-10-15 at 16:37 +0200, Lorenzo Colitti wrote:
> Rodrigo Moya wrote:
> > updated patch attached, which fixes the use of the GConfClient, found by Lorenzo.
> 
> There looks like there's still a leak in that patch. I fixed that and 
> put the result up in the bug:
> 
> http://bugzilla.gnome.org/show_bug.cgi?id=316674
> 
hmm, which leak are you fixing? The GConfClient? My code:

+       client = gconf_client_get_default ();
        show_error = gconf_client_get_bool (client,
SHOW_STARTUP_ERRORS_KEY, NULL);
+       g_object_unref (client);

the reason I did not ref it in gnome_settings_screensaver_load is that
my next patch changes all the code to use a common GConfClient, so no
need for _ref/_unref. 

So, I've committed my original patch, to HEAD only. Let me know if I
missed anything.

> The patch only covers the screensaver and typing break. Since the xrdb 
> stuff looks like it might have other small issues or leaks, shall we do 
> that separately in its own bug?
> 
> http://bugzilla.gnome.org/show_bug.cgi?id=314774
> 
> 
yes, the xrdb needs a patch/bug on its own.
-- 
Rodrigo Moya <rodrigo novell com>