Re: [PATCH] use pmount instead of mount for hotpluggable device

[David Zeuthen <david fubar dk>]

On Mon, 2006-02-13 at 10:02 +0100, Alexander Larsson wrote:
> On Sun, 2006-02-12 at 22:34 +0100, Christian Neumair wrote:
> > Without this patch I'm unable to mount previously unmounted hotpluggable
> > devices again using gnome-vfs/nautilus. The successful first time pmount
> > is probably done by the gnome-volume-manager.
> 
> I'd like to have feedback from the utopia people on this, because I
> don't really know how this is supposed to work. It strikes me as strange
> to assume /media uses pmount, because clearly not everyone does that.
> Although they probably don't have pmount installed, so it might be ok.

So I'm not sure whether this patch breaks anything (because I haven't
tested it) but this seems pretty weird

>  #if defined(USE_GNOME_MOUNT)
>                if (hal_udi != NULL && g_file_test (GNOME_VFS_BINDIR
> "/gnome-mount", G_FILE_TEST_IS_EXECUTABLE)) {
> @@ -807,15 +852,15 @@ mount_unmount_operation (const char *mou
>                        argument = "--hal-udi";
>                        name = hal_udi;
>                } else {
> -                      command = find_command (MOUNT_COMMAND);
> +                      command = find_command (is_in_media ?
> PMOUNT_COMMAND :

Why would you use pmount when building gnome-vfs with gnome-mount
support?

I also think runtime detection of what mount helper to use royally
sucks, it just makes the code look like spaghetti and it's a source of
confusion for users. The right approach, IMHO, when you want to use
pmount is to use a configure option when building gnome-vfs (just like
gnome-mount does).

    David