Am Montag, den 13.02.2006, 11:07 -0500 schrieb David Zeuthen:
> On Mon, 2006-02-13 at 10:02 +0100, Alexander Larsson wrote:
> > On Sun, 2006-02-12 at 22:34 +0100, Christian Neumair wrote:
> > > Without this patch I'm unable to mount previously unmounted hotpluggable
> > > devices again using gnome-vfs/nautilus. The successful first time pmount
> > > is probably done by the gnome-volume-manager.
> >
> > I'd like to have feedback from the utopia people on this, because I
> > don't really know how this is supposed to work. It strikes me as strange
> > to assume /media uses pmount, because clearly not everyone does that.
> > Although they probably don't have pmount installed, so it might be ok.
>
> So I'm not sure whether this patch breaks anything (because I haven't
> tested it) but this seems pretty weird
Hrm punmount is as of writing used if the "/media" check passes as well,
so that behavior should also be changed, right?
>
> > #if defined(USE_GNOME_MOUNT)
> > if (hal_udi != NULL && g_file_test (GNOME_VFS_BINDIR
> > "/gnome-mount", G_FILE_TEST_IS_EXECUTABLE)) {
> > @@ -807,15 +852,15 @@ mount_unmount_operation (const char *mou
> > argument = "--hal-udi";
> > name = hal_udi;
> > } else {
> > - command = find_command (MOUNT_COMMAND);
> > + command = find_command (is_in_media ?
> > PMOUNT_COMMAND :
>
> Why would you use pmount when building gnome-vfs with gnome-mount
> support?
I blindly replaced the old occurences of MOUNT_COMMAND by
PMOUNT_COMMAND. The old mount_unmount_operation semantics seemed to fall
back to PUMOUNT_COMMAND/PMOUNT when there is no hal UID provided.
I just made PMOUNT/PUMOUNT behavior consistent, but I have no clue
whether it is the "correct" behavior. It just ensures that for pmount,
the same helper toolchain is used for unmounting as used for mounting.
There also seem to be other users expecting the problems that made me
write the patch [1].
> I also think runtime detection of what mount helper to use royally
> sucks,
Yeah, maybe. We should probably offer a configure flag and check for
availability of the required helpers.
[1] http://bugzilla.gnome.org/show_bug.cgi?id=324839
--
Christian Neumair <chris gnome-de org>
Attachment:
signature.asc
Description: Dies ist ein digital signierter Nachrichtenteil