Re: patches for ssh

[Bastien Nocera <hadess hadess net>]

On Wed, 2003-02-12 at 10:50, Alexander Larsson wrote:
> On 11 Feb 2003, Bastien Nocera wrote:
> 
> > On Tue, 2003-02-11 at 09:51, Bastien Nocera wrote:
> > > Hello,
> > > 
> > > A small patch against HEAD that:
> > > - Give a "login failed" error when there is no key access setup to
> > > access some machine (dependant on OpenSSH, see comment)
> > > - Use port information from the URI to connect (fixes a FIXME in the
> > > code)
> > > - redirect ssh:/// to ssh://localhost/
> > > 
> > > And I couldn't reproduce that bug (could I close it?):
> > > http://bugzilla.gnome.org/show_bug.cgi?id=87668
> > > 
> > > Cheers
> > > 
> > > PS: CC: me as I'm not on this list
> > 
> > Updated the patch to wait a little while for the completion of the ssh
> > command before trying to kill it. On my network, it was killing ssh too
> > rapidly for the command to complete, hence things like
> > "do_make_directory" not working properly.
> 
> This looks fine to me. It doesn't completely help if you have a slow 
> network though. The network queue could be longer than the timeout. Its 
> certainly better than what we have now though, so please commit it.

Committed a slightly different patch, see CVS for details.

Cheers

-- 
/Bastien Nocera
http://hadess.net

#2  0x4205a2cc in printf ("Oh my %s\n", preferred_deity) from
/lib/i686/libc.so.6 printf ("Oh my %s\n", preferred_deity);
Segmentation fault