Re: Huston, we have a problem (A.K.A. Threshold vs Fixed in hicolor-0.x theme)



From the spec perspective, I think it would be the cleanest to treat
this as a theme bug,
and handle picking the best match in this case as a quality of
implementation issue.

Maybe add something like the following to the algorithm section in the spec:

Note that it is a bug if themes have directories with overlapping
match ranges, e.g.
directories with sizes 22 and 24 and a threshold of 2. The above
algorithm would
return the size 22 icon in this situation, even if size 24 was asked
for and a size 24
icon is available. Implementations might consider looking for the best
mach among
the matching non-scalable directories, rather than returning the first match.

I've written a patch to make GtkIconTheme behave like this, it is attached to
http://bugzilla.gnome.org/show_bug.cgi?id=395830


Matthias



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]