Re: Delay in extension reviews?



Hm. I looked into GtkIconTheme, and all it seems to be checking for is
the existence of a filename property, so it can load it correctly.
Looking at gtk_icon_theme_lookup_by_gicon (what we use in the Shell),
it doesn't add the filename for a GFileIcon. That's easy to fix, no?

https://bugzilla.gnome.org/show_bug.cgi?id=676356

On Sat, May 19, 2012 at 1:03 AM, Ray Strode <halfline gmail com> wrote:
> Hi,
>
> On Fri, May 18, 2012 at 8:56 PM, Jasper St. Pierre
> <jstpierre mecheye net> wrote:
>> See:
>>
>> https://mail.gnome.org/archives/gnome-shell-list/2012-May/msg00051.html
>> https://mail.gnome.org/archives/gnome-shell-list/2012-May/msg00017.html
>
> Ah, okay.  The api gtk offers for loading symbolic icons is:
>
> gtk_icon_info_load_symbolic()
>
> GtkIconInfo is a helper object specific to GtkIconTheme.  It's always
> associated with a GtkIconTheme object.  If you load something off disk
> from a specific path instead of from an icon theme, then you aren't
> getting it from a theme, so there's no GtkIconTheme object and no
> GtkIconInfo. I guess an argument could be made for adding a
> gtk_icon_info_new_from_file api.
>
> Note, all gtk_icon_info_load_symbolic is doing is something like
>
> return gdk_pixbuf_new...('<svg><style>/*stylesheet made from passed in
> colors*/</style><include href="icon-name-symbolic.svg"/></svg>');
>
> So St could probably just do that itself if there was a need for
> st_texture_cache_load_symbolic_gicon or whatever.
>
> --Ray



-- 
  Jasper


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]