Re: [gpm] Support for brightness_in_hardware hal property

[Richard Hughes <hughsient gmail com>]

On Mon, 2008-06-23 at 14:01 +0200, Tomaž Šolc wrote:
> Hi
> 
> > Can you retry svn head please? Thanks.
> 
> Thanks, that fixed the segfault.

Cool, thanks.

> OTOH there are a couple of problems
> with my patch now - the new g-p-m prefers to use xrandr to set the
> brightness, which means that my changes no longer have any effect on the
> Eee.

I should be a lot faster to set with XRANDR - is that what you found
also?

> If I force the use of HAL in gpm_brightness_init(), the brightness
> buttons work properly, but the feedback widget doesn't appear on the
> screen.

Right, I guess the gpm_brightness_xrandr_X commands are not setting
hw_changed properly.

> I'm not sure what is the correct way to solve this problem. If xrandr is
> now the preferred way, what is the best way to tell it that brightness
> buttons work in hardware?

Well, there are two ways -- preferable would be to keep track of the
last brightness and then compare the current against the last, or we
could use the hal attribute in the xrandr code. I'm not sure which is
the best to do.

Richard.