Re: [gpm] critical shutdown to low & not adjustable

[Richard Hughes <hughsient gmail com>]

On Fri, 2006-03-17 at 10:14 +0100, Ralf M�r wrote:
> Hi,
> 
> Am Donnerstag, den 16.03.2006, 22:16 +0000 schrieb Richard Hughes:
> > On Thu, 2006-03-16 at 22:56 +0100, Jaap Haitsma wrote:
> > > On Thu, 2006-03-16 at 21:47 +0000, Richard Hughes wrote:
> > > > On Thu, 2006-03-16 at 22:39 +0100, Ralf M�r wrote:
> 
> [snip]
> 
> > > > I'm in two minds about how we should fix this: should we auto-compute
> > > > the values based on the size of the battery (probably ideal, but only
> > > > available for acpi, and mediocre support at that) or just push these
> > > > into gconf.
> > > > 
> > > > I'm erring on the latter at the moment.
> 
> Yes gconf is a good idea.

I've committed this:

2006-03-19  Richard Hughes  <richard hughsie com>

* data/gnome-power-manager.schemas.in, src/gpm-prefs.h: Add:
/apps/gnome-power-manager/battery_low_percentage
/apps/gnome-power-manager/battery_very_low_percentage
/apps/gnome-power-manager/battery_critical_percentage
/apps/gnome-power-manager/battery_action_percentage
/apps/gnome-power-manager/battery_low_time
/apps/gnome-power-manager/battery_very_low_time
/apps/gnome-power-manager/battery_critical_time
/apps/gnome-power-manager/battery_action_time
/apps/gnome-power-manager/laptop_panel_dim_brightness

* src/gpm-manager.c (gpm_manager_init): Read in the values set in gconf
so that we can change the hardcoded values if required. Fixes a problem
reported by Ralf M�r, where the battery critical was set impossibly
low. Also get the LCD brightness on idle from gconf, as we are in the
area, and might want to be tweaked by distros/users.

Richard.