Re: [gpm] critical shutdown to low & not adjustable

[Jaap Haitsma <jaap haitsma org>]

On Thu, 2006-03-16 at 21:47 +0000, Richard Hughes wrote:
> On Thu, 2006-03-16 at 22:39 +0100, Ralf M�r wrote:
> > Hi,
> > 
> > the critical time (percentage) for shutdown seems to be set to 1%
> > (2min.).
> > That's pretty low, especially on laptops that run out of power faster
> > than mine.
> > 
> > So I searched in preferences, gconf-editor, /etc, man pages, website and
> > finally this list for a place to change the critical value.
> > 
> > So where can I adjust this parameter?
> 
> Ahh.
> 
> src/gpm-manager.c:
> 
> #define		BATTERY_LOW_PERCENTAGE			(10)	  /* 10 percent */
> #define		BATTERY_VERY_LOW_PERCENTAGE		(5)	  /* 5 percent  */
> #define		BATTERY_CRITICAL_PERCENTAGE		(2)	  /* 2 percent  */
> #define		BATTERY_ACTION_PERCENTAGE		(1)	  /* 1 percent  */
> 
> #define		BATTERY_LOW_REMAINING_TIME		(20 * 60) /* 20 minutes */
> #define		BATTERY_VERY_LOW_REMAINING_TIME		(10 * 60) /* 10 minutes */
> #define		BATTERY_CRITICAL_REMAINING_TIME		(5 * 60)  /* 5 minutes  */
> #define		BATTERY_ACTION_REMAINING_TIME		(2 * 60)  /* 2 minutes  */
> 
> #define		LAPTOP_PANEL_DIM_BRIGHTNESS		30 /* % */
> 
> I'm in two minds about how we should fix this: should we auto-compute
> the values based on the size of the battery (probably ideal, but only
> available for acpi, and mediocre support at that) or just push these
> into gconf.
> 
> I'm erring on the latter at the moment.
> 
> Comments?
> 
I would go for the gconf settings. In an ideal world the time based
stuff just works. If not we probably also can't trust doing any
calculations for determining the percentage automatically

Jaap