Re: [gpm] critical shutdown to low & not adjustable

[Richard Hughes <hughsient gmail com>]

On Thu, 2006-03-16 at 22:56 +0100, Jaap Haitsma wrote:
> On Thu, 2006-03-16 at 21:47 +0000, Richard Hughes wrote:
> > On Thu, 2006-03-16 at 22:39 +0100, Ralf M�r wrote:
> > > Hi,
> > > 
> > > the critical time (percentage) for shutdown seems to be set to 1%
> > > (2min.).
> > > That's pretty low, especially on laptops that run out of power faster
> > > than mine.
> > > 
> > > So I searched in preferences, gconf-editor, /etc, man pages, website and
> > > finally this list for a place to change the critical value.
> > > 
> > > So where can I adjust this parameter?
> > 
> > Ahh.
> > 
> > src/gpm-manager.c:
> > 
> > #define		BATTERY_LOW_PERCENTAGE			(10)	  /* 10 percent */
> > #define		BATTERY_VERY_LOW_PERCENTAGE		(5)	  /* 5 percent  */
> > #define		BATTERY_CRITICAL_PERCENTAGE		(2)	  /* 2 percent  */
> > #define		BATTERY_ACTION_PERCENTAGE		(1)	  /* 1 percent  */
> > 
> > #define		BATTERY_LOW_REMAINING_TIME		(20 * 60) /* 20 minutes */
> > #define		BATTERY_VERY_LOW_REMAINING_TIME		(10 * 60) /* 10 minutes */
> > #define		BATTERY_CRITICAL_REMAINING_TIME		(5 * 60)  /* 5 minutes  */
> > #define		BATTERY_ACTION_REMAINING_TIME		(2 * 60)  /* 2 minutes  */
> > 
> > #define		LAPTOP_PANEL_DIM_BRIGHTNESS		30 /* % */
> > 
> > I'm in two minds about how we should fix this: should we auto-compute
> > the values based on the size of the battery (probably ideal, but only
> > available for acpi, and mediocre support at that) or just push these
> > into gconf.
> > 
> > I'm erring on the latter at the moment.
> > 
> > Comments?
> > 
> I would go for the gconf settings. In an ideal world the time based
> stuff just works. If not we probably also can't trust doing any
> calculations for determining the percentage automatically

Sure, sounds good.

What about this as a sample schema:

key:battery_low_percentage
default:10
desc:Percentage is considered low
ldesc:The percentage of the battery when it is considered low

key:battery_very_low_percentage
default:5

key:battery_critical_percentage
default:2

key:battery_action_percentage
default:1

key:battery_low_remaining_time
default:1200
desc:The time remaining when low
ldesc:The time remaining in seconds of the battery when it is considered
low

key:battery_very_low_remaining_time
default:600

key:battery_critical_remaining_time
default:300

key:battery_action_remaining_time
default:120

key:laptop_panel_dim_brightness
default:30
desc:The brightness of the screen when session idle
ldesc:This is the laptop panel screen brightness when the session is
idle

Any better ideas or wording replacements?

Richard.