Re: New push emails



On Mon, 2009-03-16 at 18:59 +0100, Christian Persch wrote:
> Hi;
> 
> Le Mon, 09 Mar 2009 15:06:36 -0400,
> Owen Taylor <otaylor redhat com> a écrit :
> > On Mon, 2009-03-09 at 19:34 +0100, Christian Persch wrote:
> > > Could an extra header be added to the commit mails that contain the
> > > list of paths the commit modifies? The SVN commit mails have that,
> > > and I use it to filter the commit mails, e.g. to automatically
> > > mark-as-read commits that only touch po/. (For the SVN mails the
> > > paths are in the Subject:, but I like the git mails subject
> > > containing the short summary of the commit better, so an extra
> > > header would be preferred.)
> > 
> > Was discussed earlier. It would have to be defined exactly what went
> > in there - is it just the common prefix to all affected files?
> 
> No, it's the list of all subdirs of the module that contain files
> which were modified in the commit. 

Is that more useful than what I proposed? (honest question)

> Also, the git commit mails truncate the short commit msg at 50 chars,
> often in the middle of a word; is it really necessary to truncate here?

I've upped the limit to 100. I don't want to make it arbitrary, to avoid
1000 character subject lines. If you are writing more than 100 chars in
your subject, you are doing something wrong. (They tend to be
abbreviated in other places as well; IIRC, cgit chops them quite short
when its displaying a list of commits.)

- Owen




[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]