Re: Break string freeze again for GDM 2.20



2008-03-10 klockan 20:44 skrev Brian Cameron:
> Thanks for explaining.  I updated the patch as you suggest, and removed
> the gui/gdmcommon.c part of the previous patch.  The new patch which I
> did apply is attached for reference.

See my comments below.

> Index: daemon/gdm.h
> ===================================================================
> --- daemon/gdm.h	(revision 5914)
> +++ daemon/gdm.h	(working copy)
> @@ -67,6 +67,8 @@
>   */
>  #define GDM_DEFAULT_WELCOME_MSG "Welcome"
>  #define GDM_DEFAULT_REMOTE_WELCOME_MSG "Welcome to %n"
> +#define GDM_DEFAULT_WELCOME_TRANSLATED_MSG N_("Welcome")
> +#define GDM_DEFAULT_REMOTE_WELCOME_TRANSLATED_MSG N_("Welcome to %n")

Eh, GDM_DEFAULT_WELCOME_TRANSLATED_MSG and
GDM_DEFAULT_REMOTE_WELCOME_TRANSLATED_MSG are *not* translated. They will
hold the literal values "Welcome" and "Welcome to %n", just as the
non-TRANSLATED variants.

I'd suggest:

  #define GDM_DEFAULT_WELCOME_MSG N_("Welcome")
  #define GDM_DEFAULT_REMOTE_WELCOME_MSG N_("Welcome to %n")

...leaving the TRANSLATED variants out. Whenever you use the string for
display, just pass it through gettext().

  mvrgr, Wouter

-- 
:wq                                                       mail uws xs4all nl
                                                      web http://uwstopia.nl

we'd drink and get high until late :: and now we're all alone     -- placebo

Attachment: signature.asc
Description: Digital signature



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]