Sorry about the time to reply. On Thu, 2004-08-05 at 18:46 +0200, Christian Rose wrote: > > > > http://davyd.angrygoats.net/battstat.patch > return_string = g_strdup_printf("%s %s", > hours_string, mins_string); > > I don't think this will work well for RTL situations. I can imagine an > RTL translator wanting to swap the two %s so that he or she can produce > an end result that is something like "setunim 43 ruoh 1". > This means that the "%s %s" string needs to be marked for translation > (and an appropriate explaining comment be added): I had wondered about this. It's now fixed up and commented on. > /* Translation Note: The %s:s are the "%i hour" and "%i minute" messages translated elsewhere respectively. > Swap the order with "%2$s %1$s" if needed. */ > return_string = g_strdup_printf(_("%s %s"), > hours_string, mins_string); > > > This message needs a comment that explains what the %s will be replaced > with. I've added an example comment (can probably be improved): > > /* Translation Note: The %s will be replaced with the "1 hour 34 minutes" or "Unknown time" messages translated elsewhere. */ > new_label2 = g_strdup_printf (_("%s (%d%%) remaining. To avoid losing work please power off, suspend or plug your laptop in."), > new_string, batt_life); I've fixed these up too. Updated patch as per URL above. If the i18n team doesn't have any other issues I'd like to merge it as soon as possible. Thanks --d -- http://davyd.ucc.asn.au/ PGP Fingerprint <http://davyd.ucc.asn.au/pgp> 08B0 341A 0B9B 08BB 2118 C060 2EDD BB4F 5191 6CDA
Attachment:
signature.asc
Description: This is a digitally signed message part