Re: OO.o .desktop files ...

[Christian Neumair <chris gnome-de org>]

Am Mi, 2003-08-20 um 14.23 schrieb Carlos Perelló Marín:
> El mié, 20-08-2003 a las 14:07, Christian Neumair escribió:
> > Am Mi, 2003-08-20 um 13.45 schrieb Michael Meeks:
> > > Hi Carlos / Kjartan,
> > > 
> > > On Wed, 2003-08-20 at 11:23, Carlos Perelló Marín wrote:
> > > > > Sorry for not responding to this earlier. I missed it in the avalanche
> > > > > of mail I got after the summer holidays.
> > > 
> > > 	Hey - I hope you had a good time.
> > > 
> > > > Michael, Could you setup the OO.o module at cvs.gnome.org so it have a
> > > > po dir like any other "normal" module?
> > > 
> > > 	That I suppose is no problem; I'd greatly appreciate someone more
> > > expert in i18n than I doing this though. The module is 'openoffice' in
> > > Gnome CVS - and the .desktop files are the only thing we need
> > > translated, and they lurk in 'desktop/'.
> > > 
> > > 	Any takers ?
> > Yes, me :).
> 
> I have done it already.
> 
> Just finishing last bits to commit it
> 
> Sorry for not warn you :-(
> 
> Cheers.
Thanks for the efforts - mine are lost now, though.
Some suggestions, since your implementation is pretty unclean (in terms
of Ximian b0rkness compatibility :P) and therefore shouldn't be included
in any tarball, because the Ximian build system seems to have some weird
rough edges:
- Add "desktopdir -= $(datadir)/applications" to desktop/Makefile.am
after @INTLTOOL_DESKTOP_RULE@. The desktopdir is only a dummy thingie to
satisfy intltool. This file didn't contain any install routines before
you commited the patch, so it should stay the same. I'm sure Ximian uses
something "better" than a standard way to install this ;).
- Add *.desktop.in wildcard to EXTRA_DIST in desktop/Makefile.am. See
intltool docs.
- Add a Makefile.am to po containing "EXTRA_DIST = POTFILES.in
$(POFILES)" and change po/Makefile.in to po/Makefile in AC_OUTPUT in
configure.in. We don't want to install any of these po files, they
should only be included in the tarballs. Note: This makes Makefile.in.in
useless - anyway, it is installed by gettext/intltool.
The rest looks ok.

regs,
 Chris