Re: Patch to get gnome-vfs building against HEAD

[Owen Taylor <otaylor redhat com>]

Michael Meeks <michael ximian com> writes:

> On Mon, 2002-12-16 at 18:15, Jody Goldberg wrote:
> > On Mon, Dec 16, 2002 at 01:49:57PM +0000, Michael Meeks wrote:
> > > 	To a scad of configure.in's PKG_CONFIG checks ? that just has to mean
> > > that the -pthread is getting fumbled somewhere inside pkg-config -
> > > surely.
> > 
> > Its not pkg-config, its libtool.
> > The failures are for executables that are specifying their link line
> > as libfoo.la.  Where the .la is not including -pthread.  The
> > solution is to add FOO_LIBS (or whatever the pkg-config output was)
> 
> 	Fine - so I simply don't understand how this patch to configure.in
> which adds gthread-2.0 - despite that being a dependency of
> bonobo-activation-2.0 -> ORBit2 -> linc:
> 
> @@ -42,7 +42,8 @@
>                   bonobo-activation-2.0 >= 1.0.0 \
>                   libxml-2.0 >= 2.4.20 \
>                   gconf-2.0 >= 1.1.9 \
> -                 gtk+-2.0 >= 2.0.2"
> +                 gtk+-2.0 >= 2.0.2 \
> +                 gthread-2.0 >= 2.0.2"
> 
> 	can possibly make any difference;
> 
> 	Of course; I can perhaps see a Makefile.am patch adding $(FOO_CFLAGS)
> or somesuch to the build might work nicely but ...

There is some confusion here based on Kjartan's patches having
some extra stuff in them. THe above is not necessary; for libbonoboui,
the part of the patch that has an effect is the lines:

+LDADD =	$(top_builddir)/bonobo/libbonoboui-2.la $(BONOBOUI_LIBS)
 
It would also be possible to do something like:

 PKG_CHECK_MODULES(TEST, gthread-2.0 >= 2.0.2)

 LDADD =	$(top_builddir)/bonobo/libbonoboui-2.la $(TEST_LIBS)

To get it down to what is really needed, but BONOBOUI_LIBS should
work, except for having a few duplicated libraries on the link
line.

Regards,
                                        Owen