Re: [gnome-flashback] Metacity

[Alberts Muktupāvels <alberts muktupavels gmail com>]

Please review attached patch. Maybe do you have better idea?

With this patch shadow will not be added to outline_window. At least shadow is not added for me. Does this fix blinking problem?

Probably outline_window_set_have_shadow should be renamed and moved to other file as this function could be used in other places too. For example when maximizing, unmaximizing window.

On Sun, Jun 8, 2014 at 9:58 PM, Alberts Muktupāvels <alberts muktupavels gmail com> wrote:

Thanks for video.

I updated tabpopup.c, but I think it is not going to fix blinking problem.

1. There was missing white border for outline window. This is now fixed.
2. It becomes dark because of shadow. Now first window will have shadow too. There is bug about this - https://bugzilla.gnome.org/show_bug.cgi?id=536573.

I think this shadow is reason for blinking. Maybe do you know how to force that window to NOT have shadow? Shadow is created in src/compositor/compositor-xrender.c.

I think we should make it possible to tell compositor to not draw shadow for windows. For now I can think to cases where shadow is not needed:

1) Drawing shadow for outline_window when switching between windows with alt + tab.

2) Maximized windows should not have shadows too.

On Sun, Jun 8, 2014 at 8:02 AM, Dmitry Shachnev <mitya57 ubuntu com> wrote:

On Sat, Jun 7, 2014 at 8:35 PM, Alberts Muktupāvels
<alberts muktupavels gmail com> wrote:
> Can you record video with this problem. I am not sure if I have this bug. :(

http://people.ubuntu.com/~mitya57/tmp/out-2.ogv

In fact I got blinks on every pressing Tab, but only one is visible on
the video.

Also, you can see that when the switcher is opened first time, the
background is light, but after that it becomes dark.

I have compositing enabled.

--
Dmitry Shachnev
_______________________________________________
gnome-flashback-list mailing list
gnome-flashback-list gnome org
https://mail.gnome.org/mailman/listinfo/gnome-flashback-list

--

Alberts Muktupāvels

--

Alberts Muktupāvels

Attachment: 0001-tabpopup.c-don-t-show-shadow-for-outline-window.patch
Description: Text Data