Re: [gnome-flashback] [gnome-panel] Pass --session-name from desktop files.

[Philipp Kaluza <floss ghostroute eu>]

Hi Alberts, hi all,

Am 07.12.2013 12:50, schrieb Alberts Muktupāvels:
> commit cf5f81d5dc41a8d6d64ef321db4fc9456c75a4bb
> Author: Dmitry Shachnev <mitya57 gmail com>
> Date:   Wed Nov 27 18:39:46 2013 +0400
>
>     Pass --session-name from desktop files.
>     
>     And not from a wrapper script. This way we have less code and are able to specify
>     custom session names when needed.
Alberts, could you _please_ add a link to the bug in your commit
messages, so people can find the relevant bugzilla discussions from the
commit message ?

> diff --git a/data/gnome-flashback.desktop.in.in b/data/gnome-flashback.desktop.in.in
> index 915c759..8383a92 100644
> --- a/data/gnome-flashback.desktop.in.in
> +++ b/data/gnome-flashback.desktop.in.in
> @@ -1,7 +1,7 @@
>  [Desktop Entry]
>  _Name=GNOME Flashback (Metacity)
>  _Comment=This session logs you into GNOME with the traditional panel
> -Exec= libexecdir@/gnome-session-flashback
> +Exec= libexecdir@/gnome-session-flashback --session=gnome-flashback
>  TryExec= libexecdir@/gnome-session-flashback
>  Icon=
>  Type=Application

Who tested this ?

In short, I don't think this should ever have passed the bugzilla review
- there was a reason Jeremy Bicha and myself both independently
introduced a wrapper script, and that reason is that it is needed - not
all display managers can pass on parameters in this way. (If memory
serves, GDM3 is one that cannot, and is most certainly a target DM for us.)

So in short, NAK, I'll revert this.

Cheers
  Philipp

-- 
Philipp Kaluza
Ghostroute IT Consulting