Re: [gnome-db] cygwin update



On Wed, 2002-08-21 at 16:36, Margus Všli wrote:
________________________________________________________________________
> 
> Index: report/libgda-report/Makefile.am
> ===================================================================
> RCS file: /cvs/gnome/libgda/report/libgda-report/Makefile.am,v
> retrieving revision 1.8
> diff -u -r1.8 Makefile.am
> --- report/libgda-report/Makefile.am	2002/05/26 00:53:57	1.8
> +++ report/libgda-report/Makefile.am	2002/08/21 14:23:59
> @@ -17,7 +17,7 @@
>  	gda-report-document.c
>  
>  libgda_report_2_la_LDFLAGS = -version-info $(GDA_CURRENT):$(GDA_REVISION):$(GDA_AGE)
> -libgda_report_2_la_LIBADD = $(LIBGDA_LIBS)
> +libgda_report_2_la_LIBADD = $(LIBGDA_LIBS) -L$(top_builddir)/libgda/ -lgda-2 
>  
>  gdareportincludedir=$(includedir)/libgda-report
>  gdareportinclude_HEADERS=$(gda_report_headers)

this patch seems not to be correct. First of all, I don't know if it's
portable to link a libtool library (libgda-report) with another libtool
library (before being installed, that is), which in this case is
libgda-2.

If it's portable, which it can be, the correct fix would be to reference
the libtool library built before libgda-report, so:

> -libgda_report_2_la_LIBADD = $(LIBGDA_LIBS)
> +libgda_report_2_la_LIBADD = $(LIBGDA_LIBS) $(top_builddir)/libgda/libgda-2.la

that is, without any -L nor -l flag. Could you try this in cygwin,
please? If it works, I'll apply to CVS.

cheers




[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]