Re: [gnome-db] Thoughts on stability and use in world

[Mike + Julie <wingert 3 postbox acs ohio-state edu>]

good day all!


> yes, the mailing list, please.

the cvs diff of the providers/gda-sybase-server is attached to this email.

>
> I'm myself going on holidays today, so I won't have time to apply the
> patch in the next days, so please, don't desperate if I don't answer :-)

get some rest, and relax.

> this is more or less (without the procedure editor/debugger) what the
> gnomedb-fe does.
>

I've heard some talk about merging gASQL into gnome-db, if that is the case,
I just may look into adding the functionality to it.

mike

? cvs.diff
Index: gda-sybase-command.h
===================================================================
RCS file: /cvs/gnome/libgda/providers/gda-sybase-server/gda-sybase-command.h,v
retrieving revision 1.3
diff -u -r1.3 gda-sybase-command.h
--- gda-sybase-command.h	2001/07/18 23:05:42	1.3
+++ gda-sybase-command.h	2001/09/08 17:09:57
@@ -49,7 +49,7 @@
 
 gboolean gda_sybase_command_new (GdaServerCommand * cmd);
 GdaServerRecordset *gda_sybase_command_execute (GdaServerCommand * cmd,
-						GdaServerError * error,
+						GdaError * error,
 						const GDA_CmdParameterSeq *
 						params, gulong * affected,
 						gulong options);
Index: gda-sybase-connection.c
===================================================================
RCS file: /cvs/gnome/libgda/providers/gda-sybase-server/gda-sybase-connection.c,v
retrieving revision 1.11
diff -u -r1.11 gda-sybase-connection.c
--- gda-sybase-connection.c	2001/07/18 23:05:42	1.11
+++ gda-sybase-connection.c	2001/09/08 17:09:59
@@ -429,7 +429,7 @@
  */
 
 static GdaServerRecordset *
-schema_cols (GdaServerError * error,
+schema_cols (GdaError * error,
 	     GdaServerConnection * cnc,
 	     GDA_Connection_Constraint * constraints, gint length)
 {
@@ -512,7 +512,7 @@
 }
 
 static GdaServerRecordset *
-schema_procs (GdaServerError * error,
+schema_procs (GdaError * error,
 	      GdaServerConnection * cnc,
 	      GDA_Connection_Constraint * constraints, gint length)
 {
@@ -588,7 +588,7 @@
 }
 
 static GdaServerRecordset *
-schema_tables (GdaServerError * error,
+schema_tables (GdaError * error,
 	       GdaServerConnection * cnc,
 	       GDA_Connection_Constraint * constraints, gint length)
 {
@@ -664,7 +664,7 @@
 }
 
 static GdaServerRecordset *
-schema_types (GdaServerError * error,
+schema_types (GdaError * error,
 	      GdaServerConnection * cnc,
 	      GDA_Connection_Constraint * constraints, gint length)
 {
Index: gda-sybase-connection.h
===================================================================
RCS file: /cvs/gnome/libgda/providers/gda-sybase-server/gda-sybase-connection.h,v
retrieving revision 1.5
diff -u -r1.5 gda-sybase-connection.h
--- gda-sybase-connection.h	2001/07/18 23:05:42	1.5
+++ gda-sybase-connection.h	2001/09/08 17:10:00
@@ -61,7 +61,7 @@
 	gboolean cs_diag;	// wether we can use cs_diag for cslib messages
 	gboolean ct_diag;	// wether we can use ct_diag for ctlib messages
 
-	GdaServerError *error;
+	GdaError *error;
 	sybase_Error serr;
 
 	gchar *database;
@@ -80,7 +80,7 @@
 gint gda_sybase_connection_rollback_transaction (GdaServerConnection * cnc);
 GdaServerRecordset *gda_sybase_connection_open_schema (GdaServerConnection *
 						       cnc,
-						       GdaServerError * error,
+						       GdaError * error,
 						       GDA_Connection_QType t,
 						       GDA_Connection_Constraint
 						       * constraints,
Index: gda-sybase-error.c
===================================================================
RCS file: /cvs/gnome/libgda/providers/gda-sybase-server/gda-sybase-error.c,v
retrieving revision 1.4
diff -u -r1.4 gda-sybase-error.c
--- gda-sybase-error.c	2001/07/18 23:05:42	1.4
+++ gda-sybase-error.c	2001/09/08 17:10:01
@@ -62,7 +62,7 @@
 							 *);
 
 void
-gda_sybase_error_make (GdaServerError * error,
+gda_sybase_error_make (GdaError * error,
 		       GdaServerRecordset * recset,
 		       GdaServerConnection * cnc, gchar * where)
 {
@@ -85,32 +85,32 @@
 					 ("No error flag ist set, though %s "
 					  "is called. This may be a bug."),
 					 __PRETTY_FUNCTION__);
-		gda_server_error_set_description (error,
+		gda_error_set_description (error,
 						  (err_msg) ? err_msg :
 						  "Unknown error");
 	case SYBASE_ERR_SERVER:
 		err_msg = g_sprintf_servermsg ("Server Message:",
 					       &scnc->serr.server_msg);
-		gda_server_error_set_description (error,
+		gda_error_set_description (error,
 						  (err_msg) ? err_msg :
 						  "Server error");
 		break;
 	case SYBASE_ERR_CLIENT:
 		err_msg = g_sprintf_clientmsg ("Client Message:",
 					       &scnc->serr.client_msg);
-		gda_server_error_set_description (error,
+		gda_error_set_description (error,
 						  (err_msg) ? err_msg :
 						  "Client error");
 		break;
 	case SYBASE_ERR_CSLIB:
 		err_msg = g_sprintf_clientmsg ("CS-Lib Message:",
 					       &scnc->serr.cslib_msg);
-		gda_server_error_set_description (error,
+		gda_error_set_description (error,
 						  (err_msg) ? err_msg :
 						  "Cslib error");
 		break;
 	case SYBASE_ERR_USERDEF:
-		gda_server_error_set_description (error,
+		gda_error_set_description (error,
 						  (scnc->serr.
 						   udeferr_msg) ? scnc->serr.
 						  udeferr_msg :
@@ -120,24 +120,24 @@
 		}
 		break;
 	default:
-		gda_server_error_set_description (error, "Unknown error");
+		gda_error_set_description (error, "Unknown error");
 		break;
 	}
 
 	gda_log_error (_("error '%s' at %s"),
-		       gda_server_error_get_description (error), where);
+		       gda_error_get_description (error), where);
 
 	if (err_msg) {
 		g_free ((gpointer) err_msg);
 	}
 
-	gda_server_error_set_number (error, 1);
-	gda_server_error_set_source (error, "[gda-sybase]");
-	gda_server_error_set_help_file (error, _("Not available"));
-	gda_server_error_set_help_context (error, _("Not available"));
-	gda_server_error_set_sqlstate (error, _("error"));
-	gda_server_error_set_native (error,
-				     gda_server_error_get_description
+	gda_error_set_number (error, 1);
+	gda_error_set_source (error, "[gda-sybase]");
+/*  	gda_error_set_help_file (error, _("Not available")); */
+	gda_error_set_help_context (error, _("Not available"));
+	gda_error_set_sqlstate (error, _("error"));
+	gda_error_set_native (error,
+				     gda_error_get_description
 				     (error));
 }
 
@@ -191,7 +191,7 @@
 }
 
 void
-sybase_chkerr (GdaServerError * error,
+sybase_chkerr (GdaError * error,
 	       GdaServerRecordset * recset,
 	       GdaServerConnection * _cnc,
 	       GdaServerCommand * _cmd, gchar * where)
@@ -264,7 +264,7 @@
 CS_RETCODE
 sybase_exec_chk (CS_RETCODE * retvar,
 		 CS_RETCODE retval,
-		 GdaServerError * err,
+		 GdaError * err,
 		 GdaServerRecordset * rec,
 		 GdaServerConnection * cnc,
 		 GdaServerCommand * cmd, gchar * where)
@@ -275,7 +275,7 @@
 }
 
 void
-gda_sybase_messages_handle (GdaServerError * error,
+gda_sybase_messages_handle (GdaError * error,
 			    GdaServerRecordset * recset,
 			    GdaServerConnection * cnc, gchar * where)
 {
@@ -288,7 +288,7 @@
 }
 
 void
-gda_sybase_messages_handle_clientmsg (GdaServerError * error,
+gda_sybase_messages_handle_clientmsg (GdaError * error,
 				      GdaServerRecordset * recset,
 				      GdaServerConnection * cnc,
 				      gchar * where)
@@ -359,12 +359,12 @@
 }
 
 void
-gda_sybase_messages_handle_servermsg (GdaServerError * error,
+gda_sybase_messages_handle_servermsg (GdaError * error,
 				      GdaServerRecordset * recset,
 				      GdaServerConnection * cnc,
 				      gchar * where)
 {
-	GdaServerError *serverr = error;
+	GdaError *serverr = error;
 	sybase_Connection *scnc = NULL;
 	CS_RETCODE ret = CS_SUCCEED;
 	CS_INT msgcur = 0;
@@ -439,7 +439,7 @@
 }
 
 void
-gda_sybase_messages_handle_csmsg (GdaServerError * error,
+gda_sybase_messages_handle_csmsg (GdaError * error,
 				  GdaServerRecordset * recset,
 				  GdaServerConnection * cnc, gchar * where)
 {
Index: gda-sybase-error.h
===================================================================
RCS file: /cvs/gnome/libgda/providers/gda-sybase-server/gda-sybase-error.h,v
retrieving revision 1.3
diff -u -r1.3 gda-sybase-error.h
--- gda-sybase-error.h	2001/07/18 23:05:42	1.3
+++ gda-sybase-error.h	2001/09/08 17:10:01
@@ -41,7 +41,7 @@
 
 gint gda_sybase_install_error_handlers (GdaServerConnection *);
 
-void gda_sybase_error_make (GdaServerError * error,
+void gda_sybase_error_make (GdaError * error,
 			    GdaServerRecordset * recset,
 			    GdaServerConnection * cnc, gchar * where);
 
@@ -50,12 +50,12 @@
 gboolean gda_sybase_messages_install (GdaServerConnection *);
 void gda_sybase_messages_uninstall (GdaServerConnection *);
 
-void sybase_chkerr (GdaServerError *,
+void sybase_chkerr (GdaError *,
 		    GdaServerRecordset *,
 		    GdaServerConnection *, GdaServerCommand *, gchar *);
 CS_RETCODE sybase_exec_chk (CS_RETCODE *,
 			    CS_RETCODE,
-			    GdaServerError *,
+			    GdaError *,
 			    GdaServerRecordset *,
 			    GdaServerConnection *,
 			    GdaServerCommand *, gchar *);
@@ -71,18 +71,18 @@
 						 __PRETTY_FUNCTION__)
 #endif
 
-void gda_sybase_messages_handle (GdaServerError *,
+void gda_sybase_messages_handle (GdaError *,
 				 GdaServerRecordset *,
 				 GdaServerConnection *, gchar * where);
-void gda_sybase_messages_handle_clientmsg (GdaServerError *,
+void gda_sybase_messages_handle_clientmsg (GdaError *,
 					   GdaServerRecordset *,
 					   GdaServerConnection *,
 					   gchar * where);
-void gda_sybase_messages_handle_servermsg (GdaServerError *,
+void gda_sybase_messages_handle_servermsg (GdaError *,
 					   GdaServerRecordset *,
 					   GdaServerConnection *,
 					   gchar * where);
-void gda_sybase_messages_handle_csmsg (GdaServerError *,
+void gda_sybase_messages_handle_csmsg (GdaError *,
 				       GdaServerRecordset *,
 				       GdaServerConnection *, gchar * where);
 
Index: gda-sybase-recordset.c
===================================================================
RCS file: /cvs/gnome/libgda/providers/gda-sybase-server/gda-sybase-recordset.c,v
retrieving revision 1.4
diff -u -r1.4 gda-sybase-recordset.c
--- gda-sybase-recordset.c	2001/07/18 23:05:42	1.4
+++ gda-sybase-recordset.c	2001/09/08 17:10:02
@@ -357,7 +357,7 @@
 }
 
 void
-gda_sybase_init_recset_fields (GdaServerError * err,
+gda_sybase_init_recset_fields (GdaError * err,
 			       GdaServerRecordset * recset,
 			       sybase_Recordset * srecset,
 			       CS_RETCODE result_type)
Index: gda-sybase-recordset.h
===================================================================
RCS file: /cvs/gnome/libgda/providers/gda-sybase-server/gda-sybase-recordset.h,v
retrieving revision 1.3
diff -u -r1.3 gda-sybase-recordset.h
--- gda-sybase-recordset.h	2001/07/18 23:05:42	1.3
+++ gda-sybase-recordset.h	2001/09/08 17:10:02
@@ -69,7 +69,7 @@
 gint gda_sybase_recordset_close (GdaServerRecordset *);
 void gda_sybase_recordset_free (GdaServerRecordset *);
 
-void gda_sybase_init_recset_fields (GdaServerError *,
+void gda_sybase_init_recset_fields (GdaError *,
 				    GdaServerRecordset *,
 				    sybase_Recordset *, CS_RETCODE);