RE: Cannot initialise gnome-contacts-3.10.2

[John Frankish <j-frankish slb com>]

> > The patch fails to apply to gnome-contacts-3.10.1 so I applied it manually,
> but then "make" fails with the errors pasted below - I've verified that
> without the patch it compiles without problems.
>
> I suspect that when you applied it manually you retained the line referencing
> ‘local_data.margin_start’ which doesn’t exist in 3.10. You can safely delete
> that line and it should compile.
>
> The only thing the patch adds is the ‘if (local_store != null)’ check.
> The code inside it is unchanged.

Still no luck:


contacts-store.vala:331.31-331.64: warning: TelepathyGLib.AccountManager.get_valid_accounts is deprecated
contacts-view.vala:268.3-268.35: error: overriding method `Contacts.View.row_selected' is incompatible with 
base method `Gtk.ListBox.row_selected': incompatible type of parameter 1.
  public override void row_selected (ListBoxRow row) {
  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
contacts-view.vala:268.3-268.35: error: Contacts.View.row_selected: no suitable method found to override
  public override void row_selected (ListBoxRow row) {
  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

    }

    if (local_store != null) {
    var local_data = new Grid ();
    local_data.margin = 6;
    if (local_data.get_direction () == TextDirection.LTR)
      local_data.margin_left = 5;
    else
      local_data.margin_right = 5;
    local_data.set_column_spacing (10);
    local_data.set_data ("store", local_store);
    var provider_image = new Image.from_icon_name ("drive-harddisk-system-symbolic",
                                                   IconSize.DIALOG);
    local_data.add (provider_image);
    var local_label = new Label (_("Local Address Book"));
    local_data.add (local_label);
    accounts_view.add (local_data);
    if (select_active &&
        local_store == App.app.contacts_store.aggregator.primary_store) {
      var row = local_data.get_parent () as ListBoxRow;
      row_activated (row);
      }
    }

    accounts_view.show_all ();
  }
}