Re: path to fix some build problems

[Maciej Stachowiak <mjs eazel com>]

Joe Shaw <joe helixcode com> writes:

> > * Bonobo had a circular dependency with gtkhtml due to
> >   moniker-control-test.c
> > 
> > I'm committing the patch below which fixes these build problems in the
> > most obvious way (hope no one minds).
> 
> I don't see how this patch fixes the problem. First, moniker-control-test
> doesn't have an actual gtkhtml dependency (so it shouldn't be linking
> against it in the first place...), but this patch doesn't remove the
> gtkhtml dependency on moniker-test, which is still being built. Or am I
> missing something? As long as no one objects, I'm going to re-enable the
> moniker-control-test build (without linking against gtkhtml) and disable
> moniker-test.
> 

You're right about moniker-test; I didn't notice the -lgtkhtml because
I have GtkHTML on my machine and was going off a build log to fix the
bugs.

However, I don't think you are right about moniker-control-test, since
it includes gtkhtml headers and in general has a bunch of gtk_html_foo
() calls. I wouldn't mind seeing it re-enabled at all if it no longer
depended on GtkHTML. For now, I'm checking in the following patch to
remove -lgtkhtml from the moniker-test link line and correct the
spelling of moniker_test_SOURCES (which Automake seems to completely
miss somehow, as Vlad mentioned).

Feel free to fix these problems in a more elegant way.

Regards,

Maciej


Index: ChangeLog
===================================================================
RCS file: /cvs/gnome/bonobo/ChangeLog,v
retrieving revision 1.754
diff -u -r1.754 ChangeLog
--- ChangeLog   2000/11/26 11:44:15     1.754
+++ ChangeLog   2000/11/27 00:49:34
@@ -1,5 +1,10 @@
 2000-11-26  Maciej Stachowiak  <mjs eazel com>
 
+       * monikers/Makefile.am: Remove -lgtkhtml from moniker_test_LDADD,
+       and correct spelling of moniker_test_SOURCES.
+
+2000-11-26  Maciej Stachowiak  <mjs eazel com>
+
        * monikers/Makefile.am: Add -I$(top_srcdir)/bonobo to INCLUDES so
        moniker-test.c builds even if Bonobo is not already
        installed. Comment out moniker-control-test.c from the build to
Index: monikers/Makefile.am
===================================================================
RCS file: /cvs/gnome/bonobo/monikers/Makefile.am,v
retrieving revision 1.14
diff -u -r1.14 Makefile.am
--- monikers/Makefile.am        2000/11/26 11:46:47     1.14
+++ monikers/Makefile.am        2000/11/27 00:49:35
@@ -74,10 +74,10 @@
 #moniker_control_test_LDADD =          \
 #      $(moniker_ldadd) -lgtkhtml
 
-moniker_test_SOURCSE =                 \
+moniker_test_SOURCE =                  \
        moniker-test.c
 
 moniker_test_LDADD =                   \
-       $(moniker_ldadd) -lgtkhtml
+       $(moniker_ldadd)
 
 EXTRA_DIST=std-moniker.oafinfo bonobo-moniker-gunzip.oafinfo bonobo-moniker-http.oafinfo