oaf style.



Hi Maciej,

On 28 May 2000, Maciej Stachowiak wrote:
> Looks mostly good, some comments below on minor issues.
>
> > -   if (ev->_major != CORBA_NO_EXCEPTION) {
> > +   if (ev->_major != CORBA_NO_EXCEPTION)
> >             goto out;
> > -   }
> 
> Please don't do that, I like to have even single-line if consequents
> in curly braces.

	Hmm, the rest of the module is not like that, I was attempting to
homogenise the style, in fact there is only 1 other goto error case that
does this out of many. I would tend to agree with Linus' CodingStyle:

... the supply of new-lines on your screen is not a renewable resource
(think 25-line terminal screens here), you have more empty lines to put
comments on...

	Fixed anyhow.

> Please, um, add a newline at the end of the file. :-) Also, it might
> be helpful to put the bogus iid data in a separate oafinfo file
> (`broken.oafinfo' ?) just to distinguish the working stuff from the
> non-working stuff.

	Ok; split out, there will be more interesting tests to go in there
in due course.

	Regards,

		Michael.

-- 
 mmeeks@gnu.org  <><, Pseudo Engineer, itinerant idiot





[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]