Re: [gnome-boxes 2/2] Tweak the wizard UI some more



Hi

On Thu, Nov 3, 2011 at 11:32 PM, Zeeshan Ali (Khattak)
<zeeshanak gnome org> wrote:
> On Thu, Nov 3, 2011 at 7:56 PM, Zeeshan Ali (Khattak)
> <zeeshanak gnome org> wrote:
>> On Thu, Nov 3, 2011 at 7:44 PM, Marc-André Lureau
>> <marcandre lureau gmail com> wrote:
>>> nak: still looks wrong, https://castle.so/3m9d5/preview
>>
>>  Hmm.. Renders differently here:
>>
>> http://static.fi/~zeenix/tmp/boxes-maximized.png
>> http://static.fi/~zeenix/tmp/boxes-unmaximized.png
>>
>>  Its hard to fix an issue that isn't reproducible :(
>
>  I am trying to update my jhbuild environment now in hope that this
> is some recent gtk+ (or on some other layer) bug. However, since you
> can't point out why my patch doesn't work for you and since it works
> for me, should it be kept on hold?

We already discussed that patch and the various flaws on irc:

14:32 <@elmarco> zeenix: I already looked, the is an issue with label
justify, it doesn't stay on the left14:32 <@elmarco> zeenix:
furtheermore, the right padding is wrong, and just too big, it doesn't
look like https://github.com/gnome-design-team/gnome-mockups/raw/master/boxes/boxes-install2.1.png14:33
<@elmarco> and the spacing between the top label and the widget is not
equal14:33 <@elmarco> I would argue that there is a little bit too
much spacing in what you added
and you replied, but you didn't propose a better patch.

-- 
Marc-André Lureau


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]