Re: [PATCH] Update floppy.img generation in Makefile.am



On Mon, Dec 05, 2011 at 03:30:25PM +0200, Zeeshan Ali (Khattak) wrote:
> On Mon, Dec 5, 2011 at 1:23 PM, Christophe Fergeau <cfergeau redhat com> wrote:
> > 721c6fad6c54 changed how floppy.img is generated, but the
> > corresponding generation rule in Makefile.am wasn't updated. This
> > commit changes it to use the commands mentioned in 721c6fad6c54 log.
> 
>   Nice catch! Ack but please remove the image from repo in the same commit.

After our IRC chat, I wasn't sure if I should remove it or not, so I pushed
without removing. Removing it depends on whether we can assume people will
have qemu-img available or not (which is packaged separately from qemu in
fedora). The libvirt package in fedora requires qemu-img though...
I have checked that the image is regenerated during a regular build (ie
straight 'make', not 'make floppy.img) if we delete it.

Christophe

Attachment: pgpOL5rGG3vf1.pgp
Description: PGP signature



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]