Re: [g-a-devel]Installing an additional library

[Michael Meeks <michael ximian com>]

Hi Bill,

On Thu, 2002-03-28 at 15:55, Bill Haneman wrote:
> Are there potential objections to installing such a library ?

	Well - I think it would be desirable to introduce as little new API as
is necessary.

	So I think you could expose the util API - but looking at the API I
have the following ( non release related ) criticisms / suggestions:

	* guard this API with #ifdef VERY_IMMATURE etc. ;-)

	* I _suggest_ that you clarify what is going on with the 
	  mag_client API, particularly, but not exclusively:

		+ why does mag_client.h report a load of methods
		  some of which live in mag_control.c
		+ why does mag_control have a 'get_magnifier'
		  method cut and pasted from/to mag_client.c ?
		+ why have a mag_client.h at all when all the API
		  is standard CORBA API and could trivially be
		  exposed via a simple CORBA interface, involving
		  installing a single new IDL file.
		+ why do the client methods not allow a CORBA
		  magnifier parameter to be passed in ? it seems
		  strange to throw that away.

	So in short - I'm fairly unhappy with it ;-)

> I suppose I could split this out into a separate GNOME module but
> that seems quite messy, when the "right" solution seems to be
> to mark it as currently unsupported while retaining it in the module
> where it logically falls.

	Surely a nicer solution is to move it into the module where it is
needed and expose the interface to the world via a standard IDL
interface there ?

	Regards,

		Michael.

-- 
 mmeeks gnu org  <><, Pseudo Engineer, itinerant idiot