Re: Patch to compile libgnomeui



jacob berkman wrote:

On Wed, 2001-12-12 at 15:37, Ettore Perazzoli wrote:

   > this patch makes no sense.  gnome-marshal-main.c is *not* a built
   > source.

 Uhm, then this is kinda weird too:

   gnome-marshal-main.c: $(srcdir)/gnome-marshal.c $(srcdir)/gnome-marshal.h/


not really.  srcdir/gnome-marshal.[ch] *are* generated, but
gnome-marshal-main.c isn't, and auto* is dumb.

Adding explicit dependencies like this is the right way to handle things. The dependency would already be there for tarballs where all the automaticly calculated dependencies have been expanded, but won't be there for a clean checkout from CVS. Adding a rule like the above does no harm, and makes things more convenient for people getting it from CVS.

A number of other modules do this for generated files.

James.

--
Email: james daa com au
WWW:   http://www.daa.com.au/~james/






[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]