Re: Foobar patch



On Tue, Dec 11, 2001 at 04:38:46PM -0800, Chris Phelps wrote:
> /me reads manual and re-submits...

You're leaking the pixmap if you scale down.  The ref behaviour is all
stupid there and the wnck_foo_foo_get_mini_icon function doesn't ref the
pixbuf, and so I made the internal default getting function also not ref it,
but it's just strange api I think.  Something like pixbufs as return values
should either be 'const' or reffed.  Havoc?

As to the patch, feel free to commit of course

George

-- 
George <jirka 5z com>
   Let's not bicker and argue about who killed who.
                       -- Monty Python



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]