Re: orbit-idl differences

[jacob berkman <jacob ximian com>]

On Mon, 2001-08-27 at 18:14, Maciej Stachowiak wrote:
> On 27Aug2001 06:04PM (-0400), jacob berkman wrote:
> >
> > this is tripping up a gcc warning when assigning setWindowId, as a const
> > Bonobo_Control_windowId is not the same as a const CORBA_char * (right?)
> > 
> > so, which is the right way?
> > 
> > (let me know if this is unclear)
> > 
> 
> I made this change intentionally after discussing with
> Michael. Without it there were warnings in the generated skels
> themselves.

ok here's a patch to fix the warnings then, let me know if i should
commit it.

since we aren't using the id type anymore, should we just remove it and
make the idl use string explicitely?

jacob
-- 
"OOH!!!  Look at me!!  I'm Jacob Berkman!  I have a witty .signature
 that nobody fully appreciates but myself!!"  -- Anonymous

--- bonobo-control.c~	Mon Aug 27 18:01:21 2001
+++ bonobo-control.c	Mon Aug 27 23:14:30 2001
@@ -86,7 +86,7 @@
  * Return value: the X11 window id.
  **/
 guint32
-bonobo_control_x11_from_window_id (Bonobo_Control_windowId id)
+bonobo_control_x11_from_window_id (const CORBA_char *id)
 {
 	guint32 x11_id;
 	char **elements;
@@ -273,7 +273,7 @@
 
 static void
 impl_Bonobo_Control_setWindowId (PortableServer_Servant  servant,
-				 Bonobo_Control_windowId id,
+				 const CORBA_char       *id,
 				 CORBA_Environment      *ev)
 {
 	BonoboControl *control = BONOBO_CONTROL (bonobo_object_from_servant (servant));
--- bonobo-control.h~	Wed Aug  8 14:32:39 2001
+++ bonobo-control.h	Mon Aug 27 23:13:07 2001
@@ -92,7 +92,7 @@
 								    gboolean             activated,
 								    CORBA_Environment   *opt_ev);
 Bonobo_Control_windowId     bonobo_control_window_id_from_x11      (guint32              x11_id);
-guint32                     bonobo_control_x11_from_window_id      (Bonobo_Control_windowId id);
+guint32                     bonobo_control_x11_from_window_id      (const CORBA_char    *id);
 #define                     bonobo_control_windowid_from_x11(a) \
 			    bonobo_control_window_id_from_x11(a)