[Glade-devel] One-liner fix.
- From: e98cuenc free fr (Joaquin Cuenca Abela)
- Subject: [Glade-devel] One-liner fix.
- Date: Mon, 25 Aug 2003 23:32:54 +0200
I removed the glade_widget_class_new_from_name, but I've not yet touched
this one, so you can just commit.
Keep the good work!
Cheers,
-----Message d'origine-----
De : glade-devel-admin lists ximian com=20
[mailto:glade-devel-admin lists ximian com] De la part de=20
Archit Baweja
Envoy=E9 : lundi 25 ao=FBt 2003 23:01
=C0 : Paolo Borelli
Cc : glade-devel ximian com
Objet : Re: [Glade-devel] One-liner fix.
=20
=20
I think I'll wait for Joaquin to commit his catalog rework=20
patches. This seems part of his patch.
=20
Archit Baweja
=20
Paolo Borelli <pborelli katamail com> writes:
=20
On Mon, 2003-08-25 at 10:32, Archit Baweja wrote:
Hi
=20
Following is a one liner fix. A thing to note is that=20
both functions=20
glade_widget_class_get_by_name (), and=20
glade_widget_class_get_from_name () are supposed to do the same=20
thing (atleast I think so). They why do we have 2 of=20
them? We should=20
remove the old/not-used anymoreone if possible.
=20
Seems right to me and while at it you should also do the same in=20
main.c (as a matter of fact glade-3 --dump GtkWindow=20
doesn't work at=20
the
moment)
=20
On the other hand, even if I'm not a native english speaker, I like=20
the name *_get_by_name more: I took a look with a couple of quick=20
greps and in my opinion you can go all the way, remove the current=20
glade_widget_get_by_name and rename glade_widget_get_from_name.
=20
ciao
paolo
=20
_______________________________________________
Glade-devel maillist - Glade-devel lists ximian com=20
http://lists.ximian.com/mailman/listinfo/glade-devel
_______________________________________________
Glade-devel maillist - Glade-devel lists ximian com=20
http://lists.ximian.com/mailman/listinfo/glade> -devel
=20
=20
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]