Re: [Gimp-developer] Raw cppcheck full report

[Mukund Sivaraman <muks banu com>]

Hi Julien

On Wed, Sep 05, 2012 at 09:37:10PM +0200, Julien Nabet wrote:
> Hello,
> 
> I runned cppcheck, here's some reports which may interest you:
> 
> [plug-ins/common/file-pdf-save.c:1264] ->
> [plug-ins/common/file-pdf-save.c:1260]: (style) Found duplicate
> branches for if and else.
> [plug-ins/common/warp.c:1365] -> [plug-ins/common/warp.c:1362]:
> (style) Found duplicate branches for if and else.
> [plug-ins/gfig/gfig-preview.c:235] ->
> [plug-ins/gfig/gfig-preview.c:231]: (style) Found duplicate branches
> for if and else.

These have been fixed ^.

> [plug-ins/common/file-raw.c:730]: (error) Used file that is not opened.
> [plug-ins/common/file-raw.c:732]: (error) Used file that is not opened.

I don't think these two reports are correct ^.

> [plug-ins/common/value-propagate.c:395] ->
> [plug-ins/common/value-propagate.c:395]: (style) Same expression on
> both sides of '||'.

This has been fixed ^.

> [plug-ins/file-sgi/sgi-lib.c:379]: (error) Read and write operations
> without a call to a positioning function (fseek, fsetpos or rewind)
> or fflush in between result in undefined behaviour.

This has not been fixed as it needs a more thorough check ^.

> In brief, my 2 cents
> 

I appreciate that you have run this. Would you spend some time
integrating it with our build system so that we can run `make cppcheck'
or so and get these reports, if cppcheck is found on the development
machine at configure time?


Kind regards,

Mukund