[Gimp-developer] display/proof filters and "configure.ac" problem

[Elle Stone <l elle stone gmail com>]

Hello most esteemed Gimp coding gurus!

I want to start working on the display/proof filters and also start
replacing the deprecated functions in the lcms plug-in and the
display/proof filters. But I can't get Gimp to compile when I change
"configure.ac" over to point to lcms2 instead of lcms version 1. I've
beat my head against the wall for several days now, roamed the
internet looking for solutions, don't know how to fix the problem. So
I'm hoping someone can help me figure out how to change "configure.ac"

I followed the lcms2-675558.patch to make changes to "configure.ac".
Here's the error I get when I run:
./autogen.sh --prefix=$INSTALL_PREFIX --disable-gtk-doc
--disable-python --enable-debug

. . .
checking whether to turn on profiling... no
./configure: line 13168: syntax error near unexpected token `]*'
./configure: line 13168: `  *[\ \ ]-Wall[\ \      ]*) ;;'

Configure failed or did not finish!

The thing is, line 13168 looks the same in the default configure file
and in the configure file generated by the modified configure.ac:

if eval "test x$GCC = xyes"; then
  case " $CFLAGS " in
  *[\ \ ]-Wall[\ \      ]*) ;;
  *) CFLAGS="$CFLAGS -Wall" ;;
  esac

I only changed two lines of configure.ac (or three, or one, trying
different variations), following exactly the changes in
lcms2-675558.patch (replace the line with "-" with the line with "+"):

diff --git a/configure.ac b/configure.ac
index 00dd1d7..62099a2 100644
--- a/configure.ac
+++ b/configure.ac
@@ -61,7 +61,7 @@ m4_define([libcurl_required_version], [7.15.1])
 m4_define([dbus_glib_required_version], [0.70])
 m4_define([libgudev_required_version], [167])
 m4_define([exif_required_version], [0.6.15])
-m4_define([lcms_required_version], [1.16])
+m4_define([lcms_required_version], [2.3])
 m4_define([libpng_required_version], [1.2.37])


@@ -450,7 +450,7 @@ fi
 # Internationalisation
 ######################

-IT_PROG_INTLTOOL(0.40.1)
+IT_PROG_INTLTOOL([0.40.1], [no-xml])
 AM_GLIB_GNU_GETTEXT


@@ -1540,7 +1540,7 @@ AC_ARG_WITH(lcms, [  --without-lcms
build without lcms support])
 have_lcms="no (lcms support disabled)"
 if test "x$with_lcms" != xno; then
   have_lcms=yes
-  PKG_CHECK_MODULES(LCMS, lcms >= lcms_required_version,
+  PKG_CHECK_MODULES(LCMS, lcms2 >= lcms_required_version,
     AC_DEFINE(HAVE_LCMS, 1, [Define to 1 if lcms is available])
     LCMS='lcms$(EXEEXT)',
     have_lcms="no (lcms not found or unusable)")


Help! Please help!
Elle Stone

-- 
http://ninedegreesbelow.com