Re: [Gimp-developer] XDG support and better Windows configuration path



On Thu, 2012-10-11 at 16:12 +0900, Jehan Pagès wrote:
> > We can't do that, gimp_directory() returns the folder where
> > stuff is stored, and i should stay that way.
> >
> 
> I must have badly explained, because that's not what I wanted to tell.
> :-) gimp_directory() will still and always return where stuff is
> stored. No problem here. Only discussing how to determine this folder
> when the env variable is set. Basically there are 2 cases:
> 
> (1) No environment var set: gimp_directory() will return {conf-dir}/GIMP/2.10/
> where {conf-dir} depends on the platform (XDG_CONFIG_HOME on Linux,
> APPDATA on Win and NSApplicationSupportDirectory on OSX basically).
> All good.
> 
> (2) the env var is set: until now gimp_directory() would return
> $GIMP2_DIRECTORY itself.
> I propose to return $GIMP2_DIRECTORY/2.10/ instead.
> Note that the user is still choosing the root of where GIMP should
> store the configuration, and all the rest. Simply we add one level in
> the configuration tree. This way, first we make it consistent with the
> case (1). Second we can support their configuration migration.
> 
> The problem indeed when people set this variable is that when a 2.8
> users will use 2.10 for the first time, if he had this variable both
> before and now, GIMP will not consider the user's configuration to be
> a 2.8. Hence no migration will happen. In most cases, that should be
> ok (as the migration is mostly about copy-pasting files and folders).
> But if something changed and we want to actually do something other
> than copy-pasting, these users will be the only one where the
> migration will fail.

Um, please not :) Whoever sets this globally in their env essentially
broke multiple gimp versions already anyway. GIMP2_DIRECTORY is
for development and for launcher scripts, you would say:

GIMP2_DIRECTORY="~/.config/GIMP/2.10-alternative" gimp-2.10

if you have a second GIMP version around. Returning only the base
"GIMP" path would create more messy folder trees. Let's keep
it simple :)

--mitch




[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]