Re: [Gegl-developer] [PATCH 1/1] cl: Make noise-simplex kernel OpenCL 1.1 complaint

[scl <scl gplus gmail com>]

On  5.6.2014 at 3:09 PM Jan Vesely wrote:
> gentle ping
>
> On Sun, 2014-05-18 at 16:38 -0400, Jan Vesely wrote:
> > No static keyword, f suffix for float constants
> > Fixes one error and 7 warnings

Hi Jan,

first of all thank you for your work!
I'm more active in the GIMP project than in GEGL,
but I appreciate your efforts and would like to
push it a bit further, so here we go:

- Is your code tested or can you provide test
drivers that fit into the GEGL codebase?
- I could try to test the code, but I only have
Linux in a Virtualbox VM. Can you tell whether
Mesa/Gallium3d/OpenCL would work in such an
environment?
- Are there any side effects of the patch known
(especially from making the static variable
a non-static one)?

Kind regards,

Sven