Re: [Gegl-developer] [PATCH 1/1] cl: Make noise-simplex kernel OpenCL 1.1 complaint


thank you for your response.

On Sat, 2014-06-07 at 22:31 +0200, scl wrote:
On  5.6.2014 at 3:09 PM Jan Vesely wrote:
gentle ping

On Sun, 2014-05-18 at 16:38 -0400, Jan Vesely wrote:
No static keyword, f suffix for float constants
Fixes one error and 7 warnings

Hi Jan,

first of all thank you for your work!
I'm more active in the GIMP project than in GEGL,
but I appreciate your efforts and would like to
push it a bit further, so here we go:

- Is your code tested or can you provide test
drivers that fit into the GEGL codebase?

yes, the noise-simplex.xml test passes on my AMD TURKS gpu (Radeon HD
I'm not sure how to provide a test driver. I also ran the gegl testsuite
on Intel OCL SDK and this patch does not change any result (all tests

- I could try to test the code, but I only have
Linux in a Virtualbox VM. Can you tell whether
Mesa/Gallium3d/OpenCL would work in such an

It won't. VBox does not use mesa at all. you'd need linux running on a
machine with amd gpu to test it, as well as recent versions of mesa,
clang, llvm, and libclc .
It should be possible to test ocl 1.1 syntax using clang CLC frontend
but I have not investigated it.

- Are there any side effects of the patch known
(especially from making the static variable
a non-static one)?

No side effects.
static keyword is removed from a function not variable (although it's
not supported for either in OCL 1.1)

this patch is in line with previous modifications to make ocl kernels
ocl 1.1 complaint:

the only difference is that this time the associated .h file is not in
the repository (not sure if it's intentional)

thank you,

Kind regards,


gegl-developer-list mailing list
List address:    gegl-developer-list gnome org
List membership:

Jan Vesely <jan vesely rutgers edu>

Attachment: signature.asc
Description: This is a digitally signed message part

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]