Re: [gdm-list] [Fwd: About GDM XDMCP]

[Ray Strode <halfline gmail com>]

Hi,

On Wed, Jun 16, 2010 at 6:47 PM, mariodebian <mariodebian gmail com> wrote:
> You need to apply same patch to:
>
>       gui/simple-chooser/gdm-host-chooser-widget.c
>
> (search for XdmcpFill )
>
Thanks, fixed.

> When build with this patch compiler drops a new warning:
>
> gdm-xdmcp-display-factory.c: In function 'decode_packet':
> gdm-xdmcp-display-factory.c:2890: warning: dereferencing pointer
> 'clnt_ss.284' does break strict-aliasing rules
> gdm-xdmcp-display-factory.c:2890: note: initialized from here
>
> 2890 line is:
>
> ss_len = (int)gdm_sockaddr_len (&clnt_ss);

Okay, I commited a change that should fix that:

http://git.gnome.org/browse/gdm/commit/?id=7b1e47a97d941c59599974ea421e68e1e682d70a

>> I've commited a fix here:
>>
>> http://git.gnome.org/browse/gdm/commit/?id=f8da7fc999ba46431ffbb5b562f9b35c88a0fd2d
> You need to replace other _gdm_address_debug in
> gdm_address_get_hostname() or remove to not create a loop.
mccann fixed this one up.

--Ray