Re: [gdm-list] [Fwd: About GDM XDMCP]

[Ray Strode <halfline gmail com>]

Hi,

> without patches log says
>
> gdm3[21907]: DEBUG(+): GdmXdmcpDisplayFactory: decode_packet:
> GIOCondition 1
> gdm3[21907]: DEBUG(+): GdmXdmcpDisplayFactory: Could not create XDMCP
> buffer!
>
> I compare GDM code with XDM or KDM and found that socket len variable is
> initialized before calling XdmcpFill()

I just fixed this bug today actually! Weird coincidence.

> I just found this commit in git:
>
> http://git.gnome.org/browse/gdm/commit/?id=86ac166294f0fc8f662031167066acf1928cf139

Oh yea, that's the commit.

> and tried with bad results...
> gdm crash (see attached gdm.xdmcp.crash.txt)
Weird.  Can you get a trace with dbg packages installed?

> I discover another bug in common/gdm-address.c
>
> in gdm_address_debug() you call _gdm_address_debug with ¿local vars? and
> _gdm_debug_address don't show hostname, hosts or port.
>
> In gdm_address_debug the vars are printed OK.
>
> Why this code ????
>
>        hostname = NULL;
>        host = NULL;
>        port = NULL;
>
> in _gdm_debug_address()
Ah, yea nice find.  That was apparently introduced in this commit
unintentionally:

commit 4b1263a30b2ffa9c4df8d69f857d4eefce289f55
Author: Brian Cameron <Brian Cameron sun com>
Date:   Wed Jan 13 09:32:19 2010 -0500

    Don't try to print NULL values

    This causes crashes on Solaris.

    See https://bugzilla.gnome.org/show_bug.cgi?id=494817

I've commited a fix here:

http://git.gnome.org/browse/gdm/commit/?id=f8da7fc999ba46431ffbb5b562f9b35c88a0fd2d

--Ray