> > http://git.gnome.org/browse/gdm/commit/?id=86ac166294f0fc8f662031167066acf1928cf139 > > Oh yea, that's the commit. > You need to apply same patch to: gui/simple-chooser/gdm-host-chooser-widget.c (search for XdmcpFill ) When build with this patch compiler drops a new warning: gdm-xdmcp-display-factory.c: In function 'decode_packet': gdm-xdmcp-display-factory.c:2890: warning: dereferencing pointer 'clnt_ss.284' does break strict-aliasing rules gdm-xdmcp-display-factory.c:2890: note: initialized from here 2890 line is: ss_len = (int)gdm_sockaddr_len (&clnt_ss); > > and tried with bad results... > > gdm crash (see attached gdm.xdmcp.crash.txt) > Weird. Can you get a trace with dbg packages installed? > Upsss the crash was a typo in one of my g_debug new lines... gdm don't crash anymore but try to reply to IPV6 address see attached gdm.xdmcp.ipv6.txt if client makes a QUERY in 192.168.0.3, why server try to connect to ::2820:8ebf:a52e:56b7 ??? > > I discover another bug in common/gdm-address.c > > > > in gdm_address_debug() you call _gdm_address_debug with ¿local vars? > and > > _gdm_debug_address don't show hostname, hosts or port. > > > > In gdm_address_debug the vars are printed OK. > > > > Why this code ???? > > > > hostname = NULL; > > host = NULL; > > port = NULL; > > > > in _gdm_debug_address() > Ah, yea nice find. That was apparently introduced in this commit > unintentionally: > > commit 4b1263a30b2ffa9c4df8d69f857d4eefce289f55 > Author: Brian Cameron <Brian Cameron sun com> > Date: Wed Jan 13 09:32:19 2010 -0500 > > Don't try to print NULL values > > This causes crashes on Solaris. > > See https://bugzilla.gnome.org/show_bug.cgi?id=494817 > > I've commited a fix here: > > http://git.gnome.org/browse/gdm/commit/?id=f8da7fc999ba46431ffbb5b562f9b35c88a0fd2d You need to replace other _gdm_address_debug in gdm_address_get_hostname() or remove to not create a loop. Many thanks for your help PD.- I just subscribed to gdm-list g o -- Greetings -- http://mariodebian.com
Jun 17 00:34:19 localhost gdm3[5697]: DEBUG(+): GdmXdmcpDisplayFactory: decode_packet: GIOCondition 1 Jun 17 00:34:19 localhost gdm3[5697]: DEBUG(+): decode_packet() XdmcpFill done Jun 17 00:34:19 localhost gdm3[5697]: DEBUG(+): decode_packet() XdmcpReadHeader done Jun 17 00:34:19 localhost gdm3[5697]: DEBUG(+): decode_packet() gdm_address_new_from_sockaddr done Jun 17 00:34:19 localhost gdm3[5697]: DEBUG(+): Address family:2 (inet) hostname:localhost host:127.0.0.1 port:0 local:1 loopback:1 Jun 17 00:34:19 localhost gdm3[5697]: DEBUG(+): Address family:2 (inet) hostname:thinkpad host:192.168.0.3 port:0 local:0 loopback:0 Jun 17 00:34:19 localhost gdm3[5697]: DEBUG(+): GdmAddress: looking up hostname: thinkpad Jun 17 00:34:19 localhost gdm3[5697]: DEBUG(+): family=2 sock_type=1 protocol=6 flags=0x2 canonname=localhost#012 Jun 17 00:34:19 localhost gdm3[5697]: DEBUG(+): family=2 sock_type=2 protocol=17 flags=0x2 canonname=(null)#012 Jun 17 00:34:19 localhost gdm3[5697]: DEBUG(+): family=2 sock_type=3 protocol=0 flags=0x2 canonname=(null)#012 Jun 17 00:34:19 localhost gdm3[5697]: DEBUG(+): family=2 sock_type=1 protocol=6 flags=0x2 canonname=(null)#012 Jun 17 00:34:19 localhost gdm3[5697]: DEBUG(+): family=2 sock_type=2 protocol=17 flags=0x2 canonname=(null)#012 Jun 17 00:34:19 localhost gdm3[5697]: DEBUG(+): family=2 sock_type=3 protocol=0 flags=0x2 canonname=(null)#012 Jun 17 00:34:19 localhost gdm3[5697]: DEBUG(+): family=2 sock_type=1 protocol=6 flags=0x2 canonname=(null)#012 Jun 17 00:34:19 localhost gdm3[5697]: DEBUG(+): family=2 sock_type=2 protocol=17 flags=0x2 canonname=(null)#012 Jun 17 00:34:19 localhost gdm3[5697]: DEBUG(+): family=2 sock_type=3 protocol=0 flags=0x2 canonname=(null)#012 Jun 17 00:34:19 localhost gdm3[5697]: DEBUG(+): Address family:10 (inet6) hostname:::2820:8ebf:a52e:56b7 host:::2820:8ebf:a52e:56b7 port:37292 local:0 loopback:0 Jun 17 00:34:19 localhost gdm3[5697]: DEBUG(+): decode_packet() gdm_address_get_numeric_info host=::2820:8ebf:a52e:56b7 port=37292 Jun 17 00:34:19 localhost gdm3[5697]: DEBUG(+): GdmXdmcpDisplayFactory: Received opcode QUERY from client ::2820:8ebf:a52e:56b7 : 37292 Jun 17 00:34:19 localhost gdm3[5697]: DEBUG(+): GdmXdmcpDisplayFactory: Sending WILLING to ::2820:8ebf:a52e:56b7 Jun 17 00:34:21 localhost gdm3[5697]: DEBUG(+): GdmXdmcpDisplayFactory: decode_packet: GIOCondition 1 Jun 17 00:34:21 localhost gdm3[5697]: DEBUG(+): decode_packet() XdmcpFill done Jun 17 00:34:21 localhost gdm3[5697]: DEBUG(+): decode_packet() XdmcpReadHeader done Jun 17 00:34:21 localhost gdm3[5697]: DEBUG(+): decode_packet() gdm_address_new_from_sockaddr done Jun 17 00:34:21 localhost gdm3[5697]: DEBUG(+): Address family:10 (inet6) hostname:::2820:8ebf:a52e:56b7 host:::2820:8ebf:a52e:56b7 port:37292 local:0 loopback:0 Jun 17 00:34:21 localhost gdm3[5697]: DEBUG(+): decode_packet() gdm_address_get_numeric_info host=::2820:8ebf:a52e:56b7 port=37292 Jun 17 00:34:21 localhost gdm3[5697]: DEBUG(+): GdmXdmcpDisplayFactory: Received opcode QUERY from client ::2820:8ebf:a52e:56b7 : 37292 Jun 17 00:34:21 localhost gdm3[5697]: DEBUG(+): GdmXdmcpDisplayFactory: Sending WILLING to ::2820:8ebf:a52e:56b7 Jun 17 00:34:25 localhost gdm3[5697]: DEBUG(+): GdmXdmcpDisplayFactory: decode_packet: GIOCondition 1 Jun 17 00:34:25 localhost gdm3[5697]: DEBUG(+): decode_packet() XdmcpFill done Jun 17 00:34:25 localhost gdm3[5697]: DEBUG(+): decode_packet() XdmcpReadHeader done Jun 17 00:34:25 localhost gdm3[5697]: DEBUG(+): decode_packet() gdm_address_new_from_sockaddr done Jun 17 00:34:25 localhost gdm3[5697]: DEBUG(+): Address family:2 (inet) hostname:localhost host:127.0.0.1 port:0 local:1 loopback:1 Jun 17 00:34:25 localhost gdm3[5697]: DEBUG(+): Address family:2 (inet) hostname:thinkpad host:192.168.0.3 port:0 local:0 loopback:0 Jun 17 00:34:25 localhost gdm3[5697]: DEBUG(+): GdmAddress: looking up hostname: thinkpad Jun 17 00:34:25 localhost gdm3[5697]: DEBUG(+): family=2 sock_type=1 protocol=6 flags=0x2 canonname=localhost#012 Jun 17 00:34:25 localhost gdm3[5697]: DEBUG(+): family=2 sock_type=2 protocol=17 flags=0x2 canonname=(null)#012 Jun 17 00:34:25 localhost gdm3[5697]: DEBUG(+): family=2 sock_type=3 protocol=0 flags=0x2 canonname=(null)#012 Jun 17 00:34:25 localhost gdm3[5697]: DEBUG(+): family=2 sock_type=1 protocol=6 flags=0x2 canonname=(null)#012 Jun 17 00:34:25 localhost gdm3[5697]: DEBUG(+): family=2 sock_type=2 protocol=17 flags=0x2 canonname=(null)#012 Jun 17 00:34:25 localhost gdm3[5697]: DEBUG(+): family=2 sock_type=3 protocol=0 flags=0x2 canonname=(null)#012 Jun 17 00:34:25 localhost gdm3[5697]: DEBUG(+): family=2 sock_type=1 protocol=6 flags=0x2 canonname=(null)#012 Jun 17 00:34:25 localhost gdm3[5697]: DEBUG(+): family=2 sock_type=2 protocol=17 flags=0x2 canonname=(null)#012 Jun 17 00:34:25 localhost gdm3[5697]: DEBUG(+): family=2 sock_type=3 protocol=0 flags=0x2 canonname=(null)#012 Jun 17 00:34:25 localhost gdm3[5697]: DEBUG(+): Address family:10 (inet6) hostname:::2820:8ebf:a52e:56b7 host:::2820:8ebf:a52e:56b7 port:37292 local:0 loopback:0 Jun 17 00:34:25 localhost gdm3[5697]: DEBUG(+): decode_packet() gdm_address_get_numeric_info host=::2820:8ebf:a52e:56b7 port=37292 Jun 17 00:34:25 localhost gdm3[5697]: DEBUG(+): GdmXdmcpDisplayFactory: Received opcode QUERY from client ::2820:8ebf:a52e:56b7 : 37292 Jun 17 00:34:25 localhost gdm3[5697]: DEBUG(+): GdmXdmcpDisplayFactory: Sending WILLING to ::2820:8ebf:a52e:56b7
Attachment:
signature.asc
Description: This is a digitally signed message part