[gdm-list] Recent crash problem on Solaris

[Brian Cameron <Brian Cameron Sun COM>]

After updating to the latest GDM SVN head, I noticed that GDM started
crashing on Solaris.  It would start up the Xserver okay, but it would
just hang there and never start the greeter.

According to truss, it seems that one of the processes (I think the
simple-slave) was crashing with a SEGV immediately after receiving the
USR1 signal from the Xserver.

It took me quite a while to figure out what change caused this problem,
Backing out the change to common/gdm-signal-handler.c so that setup
handler->priv->lookup is created with g_hash_table_new_full instead of
g_hash_table_new fixes the crashing problem with the simple-server.
Refer to the patch that fixes the crash problem.

I also found that leaving the g_hash_table_new_full call in place,
but commenting out the code in the signal_list_free function also avoids
the crash.

I'm not sure what the right fix is here.  I'm happy to do some
additional debugging if you have any suggestions of what to look
for.

Brian


Index: gdm-signal-handler.c
===================================================================
--- gdm-signal-handler.c	(revision 5374)
+++ gdm-signal-handler.c	(working copy)
@@ -322,10 +322,7 @@
 
         handler->priv = GDM_SIGNAL_HANDLER_GET_PRIVATE (handler);
 
-        handler->priv->lookup = g_hash_table_new_full (NULL,
-                                                       NULL,
-                                                       NULL,
-                                                       (GDestroyNotify)signal_list_free);
+        handler->priv->lookup = g_hash_table_new (NULL, NULL);
 
         if (pipe (signal_pipes) == -1) {
                 g_error ("Could not create pipe() for signal handling");