Garnome feature request (was Re: tarball with tar.gz ext)



Tomasz Król wrote:

Hi.

Well - looks like you should edit every single Makefile into garmome set and
change tar.bz2 extension in it into tar.gz... And change all checksums in
checksums file of course ("make makesum"?)... Is it realy worth of work?
Short shell script with grep should allow you to do so easly but the esiest
way is to download (or let garnome to download itself) all needed tar.bz2
files ;-)
Actually, this is one thing which should be put into category.mk instead of the individual Makefile.

This is statistics produced in garnome-0.22.0/gnome directory:

# grep -h DISTFILES */Makefile | sort | uniq -c
     1 DISTFILES = $(GARNAME)-$(GARVERSION)-2.src.rpm rpm2cpio
     1 DISTFILES = $(GARNAME)_$(GARVERSION).orig.tar.gz
   112 DISTFILES = $(GARNAME)-$(GARVERSION).tar.bz2
     1 DISTFILES = $(GARNAME)-$(GARVERSION).tar.bz2 $(SPLASH_IMAGE)
    27 DISTFILES = $(GARNAME)-$(GARVERSION).tar.gz
     1 DISTFILES = $(GARNAME)-$(GARVERSION).tgz

This implies that DISTFILES should be set to $(GARNAME)-$(GARVERSION).tar.bz2 in garnome-0.22.0/gnome/category.mk, which would cover 112 (actually 113, if we just append the $(SPLASH_IMAGE) to DISTFILES in corresponding Makefile) packages, and should be overridden in the rest 31 (30) packages.

Of course, this would raise the problem of checksums, but it can be resolved simply by including checksums for both gzipped and bzipped tarballs. This would certainly be a much better solution.

The other idea might be including a "preferred tarball compression" in "gar.conf.mk" as a variable which would work for all garballs which are known to have both available (this should work for all tarballs from ftp.gnome.org).

This would also work for garnome-0.22.0/kde (18 bzipped/conforming to 2 other tarball's), but not that well for garnome-0.22.0/misc (fcpackage tops with 4, a RPM package, 2 bzipped, and a couple gzipped tarballs).

Should I file a bug at the Bugzilla (with a patch)?

Cheers,
Danilo




[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]