Re: [evolution-patches] shell: when configuring, iconv_detect.c is not found

[Harish Krishnaswamy <kharish novell com>]

On Mon, 2005-10-24 at 16:29 +0800, Irene wrote:
> hi, Harish
> 
> 	We investigated into the iconv-detect thing and saw that the situation
> is exactly the same as you've described. I created a new patch. Please
> review. Please note that, additional to the patch, iconv-detect.h should
> also be removed from the cvs server manually. 
> 

I had added this to my to-do list right after the review - so went ahead
and committed
it  before noticing your revised patch..
iconv-detect.h has been removed as well (after tagging the release...you
might still see it
just one more time)...

thanks anyway,
Harish
> Thanks 
> 
> --Irene 
> 
> On Sat, 2005-10-22 at 19:40, Harish Krishnaswamy wrote:
> > hi Irene,
> > 
> > On Wed, 2005-10-12 at 15:38 +0800, Shiying Irene Huang wrote:
> > > hi, maintainers of evolution
> > 
> > The iconv-detect.[ch] files were inherited by evolution during the gal
> > merger.
> > 
> > >     When I re-configure evolution after running "make distclean" I found 
> > > in the log a message saying: "iconv_detect.c: no such file or 
> > > directory".  This is so, because iconv_detect.c is included in 
> > > DISTCLEANFILES and is removed after running "make distclean".
> > I feel iconv-detect.h (generated file) should be included in the distclean
> > not iconv-detect.c. I guess this was a typo introduced during the
> > merging of
> > gal code. I also observe that this has been checked in to the CVS too,
> > where it does not belong.
> > 
> > > Moreover, the file iconv_detect.h which is also necessary for 
> > > configuring is not included in EXTRA_DIST (in Makefile.am), in our 
> > > opinion, this should also be included when releasing evolution tarballs. 
> > I do not see why. 
> > iconv-detect.h is generated from the iconv-detect.c file (which is
> > distributed). (refer iconv-detect.c:101). Distributing it would be in
> > error as much as that it is in the CVS
> > sources.
> > 
> > Let me know if you think otherwise.
> > 
> > Thanks,
> > Harish
> > 
> >