Re: [evolution-patches] shell: when configuring, iconv_detect.c is not found

[Harish Krishnaswamy <kharish novell com>]

hi Irene,

On Wed, 2005-10-12 at 15:38 +0800, Shiying Irene Huang wrote:
> hi, maintainers of evolution

The iconv-detect.[ch] files were inherited by evolution during the gal
merger.

>     When I re-configure evolution after running "make distclean" I found 
> in the log a message saying: "iconv_detect.c: no such file or 
> directory".  This is so, because iconv_detect.c is included in 
> DISTCLEANFILES and is removed after running "make distclean".
I feel iconv-detect.h (generated file) should be included in the distclean
not iconv-detect.c. I guess this was a typo introduced during the
merging of
gal code. I also observe that this has been checked in to the CVS too,
where it does not belong.

> Moreover, the file iconv_detect.h which is also necessary for 
> configuring is not included in EXTRA_DIST (in Makefile.am), in our 
> opinion, this should also be included when releasing evolution tarballs. 
I do not see why. 
iconv-detect.h is generated from the iconv-detect.c file (which is
distributed). (refer iconv-detect.c:101). Distributing it would be in
error as much as that it is in the CVS
sources.

Let me know if you think otherwise.

Thanks,
Harish