[evolution-patches] shell: when configuring, iconv_detect.c is not found



hi, maintainers of evolution

When I re-configure evolution after running "make distclean" I found in the log a message saying: "iconv_detect.c: no such file or directory". This is so, because iconv_detect.c is included in DISTCLEANFILES and is removed after running "make distclean".

Moreover, the file iconv_detect.h which is also necessary for configuring is not included in EXTRA_DIST (in Makefile.am), in our opinion, this should also be included when releasing evolution tarballs.

Herewith, I submit a patch for this spotted problems for your review.
Thank you very much .

Irene Huang
Index: ChangeLog
===================================================================
RCS file: /cvs/gnome/evolution/ChangeLog,v
retrieving revision 1.1527
diff -u -r1.1527 ChangeLog
--- ChangeLog	3 Oct 2005 05:46:08 -0000	1.1527
+++ ChangeLog	12 Oct 2005 07:16:34 -0000
@@ -1,3 +1,11 @@
+2005-10-12  Irene Huang <Irene Huang sun com>
+
+	* Makefile.am: iconv_detect.h should be included in EXTRA_DIST.
+	iconv_detect.c shouldn't be removed when runing make distclean.
+	These two files are necessary for configuring, or an error will
+	pop up.
+
+
 2005-10-3  Harish Krishnaswamy <kharish novell com>
 
 	* marshal.mk : do not add the srcdir prefix as
Index: Makefile.am
===================================================================
RCS file: /cvs/gnome/evolution/Makefile.am,v
retrieving revision 1.103
diff -u -r1.103 Makefile.am
--- Makefile.am	17 Jun 2005 15:20:22 -0000	1.103
+++ Makefile.am	12 Oct 2005 07:16:35 -0000
@@ -21,6 +21,7 @@
 	NEWS-1.0		\
 	marshal.mk		\
 	iconv-detect.c		\
+	iconv-detect.h		\
 	plugin.mk		\
 	server.mk		\
 	intltool-merge.in	\
@@ -53,7 +54,7 @@
 	help			\
 	po
 
-DISTCLEANFILES = intltool-extract intltool-merge intltool-update iconv-detect.c $(pkgconfig_DATA)
+DISTCLEANFILES = intltool-extract intltool-merge intltool-update $(pkgconfig_DATA)
 
 # CDE Stuff
 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]