Re: [evolution-patches] shell: when configuring, iconv_detect.c is not found

[Irene <Irene Huang Sun COM>]

hi, Harish

	We investigated into the iconv-detect thing and saw that the situation
is exactly the same as you've described. I created a new patch. Please
review. Please note that, additional to the patch, iconv-detect.h should
also be removed from the cvs server manually. 

Thanks 

--Irene 

On Sat, 2005-10-22 at 19:40, Harish Krishnaswamy wrote:
> hi Irene,
> 
> On Wed, 2005-10-12 at 15:38 +0800, Shiying Irene Huang wrote:
> > hi, maintainers of evolution
> 
> The iconv-detect.[ch] files were inherited by evolution during the gal
> merger.
> 
> >     When I re-configure evolution after running "make distclean" I found 
> > in the log a message saying: "iconv_detect.c: no such file or 
> > directory".  This is so, because iconv_detect.c is included in 
> > DISTCLEANFILES and is removed after running "make distclean".
> I feel iconv-detect.h (generated file) should be included in the distclean
> not iconv-detect.c. I guess this was a typo introduced during the
> merging of
> gal code. I also observe that this has been checked in to the CVS too,
> where it does not belong.
> 
> > Moreover, the file iconv_detect.h which is also necessary for 
> > configuring is not included in EXTRA_DIST (in Makefile.am), in our 
> > opinion, this should also be included when releasing evolution tarballs. 
> I do not see why. 
> iconv-detect.h is generated from the iconv-detect.c file (which is
> distributed). (refer iconv-detect.c:101). Distributing it would be in
> error as much as that it is in the CVS
> sources.
> 
> Let me know if you think otherwise.
> 
> Thanks,
> Harish
> 
> 

Index: ChangeLog
===================================================================
RCS file: /cvs/gnome/evolution/ChangeLog,v
retrieving revision 1.1530
diff -u -r1.1530 ChangeLog
--- ChangeLog	19 Oct 2005 11:38:13 -0000	1.1530
+++ ChangeLog	24 Oct 2005 07:46:33 -0000
@@ -1,3 +1,8 @@
+2005-10-24  Irene Huang <Irene Huang sun com>
+
+	* Makefile.am: iconv_detect.c in DISTCLEANFILES 
+	should be iconv_detect.h.
+
 2005-10-19  Harish Krishnaswamy <kharish novell com>
 
 	Committing for Nathan Owens <pianocomp81 yahoo com>
Index: Makefile.am
===================================================================
RCS file: /cvs/gnome/evolution/Makefile.am,v
retrieving revision 1.103
diff -u -r1.103 Makefile.am
--- Makefile.am	17 Jun 2005 15:20:22 -0000	1.103
+++ Makefile.am	24 Oct 2005 07:46:34 -0000
@@ -53,7 +53,7 @@
 	help			\
 	po
 
-DISTCLEANFILES = intltool-extract intltool-merge intltool-update iconv-detect.c $(pkgconfig_DATA)
+DISTCLEANFILES = intltool-extract intltool-merge intltool-update iconv-detect.h $(pkgconfig_DATA)
 
 # CDE Stuff