Re: [evolution-patches] Patch for camel-mime-part.c

[Vivek Jain <jvivek novell com>]

On Mon, 2005-10-17 at 12:01 -0400, Jeffrey Stedfast wrote:
> On Mon, 2005-10-17 at 14:40 +0530, Vivek Jain wrote:
> 
> this is not a proper fix for that. g_return is an assertion, not "error
> handling".
> 
> if there are problems with callers passing invalid objects to
> camel_mime_part_* functions, then there are bugs in the callers and that
> is where you need to fix the problems.

 camel-gpg-context.c

 1631  content = camel_medium_get_content_object((CamelMedium *)ipart);
 1632  ct = camel_mime_part_get_content_type((CamelMimePart *)content);

Do you suggest to have a check on "content" before we call
(camel_mime_part_get_content_type) since it can be NULL in erroneous
situations? See bug # 315012.


Thanks,
Vivek Jain




>