Re: [evolution-patches] Patch for camel-mime-part.c

[Jeffrey Stedfast <fejj novell com>]

On Mon, 2005-10-17 at 14:40 +0530, Vivek Jain wrote:
> hi,
> 
> I am attaching a patch which adds g_return 's at appropriate places in
> camel-mime-part.c.
> 
> These interfaces (_get functions basically) need to check for the valid
> object before accessing any data member of this struct. This will help
> in making application more stable by handling the cases when caller did
> not care to check for the validity. The patch does that.

this is not a proper fix for that. g_return is an assertion, not "error
handling".

if there are problems with callers passing invalid objects to
camel_mime_part_* functions, then there are bugs in the callers and that
is where you need to fix the problems.

-- 
Jeffrey Stedfast
Evolution Hacker - Novell, Inc.
fejj ximian com  - www.novell.com