Re: [evolution-patches] Patch for the bug # 309869

[Antony Vincent Pandian <santony gmail com>]

       Hereby i attach the corrected and
revised patch with widget pointer comparison with its changelog.

On 7/13/05, Not Zed <notzed ximian com> wrote:

i.e. this means:

        if (button == hdrs->priv->cc.label)
                /* the 'cc' button was pressed */;
        etc.

I dont know how you thought a different strcmp implementation wasn't
just 'comparing strings'.


On Wed, 2005-07-13 at 15:32 +0800, Not Zed wrote:
> No, when i said pointer comparisons, i meant nothing to do with the
> strings at all.
>
> i.e. compare the widget pointers.
>
>
> On Wed, 2005-07-13 at 12:28 +0530, Antony Vincent Pandian wrote:
> >
> >          Here's the patch with no usage of strcmp. i have written a
> > function string_compare() which does pointer comparisons.
> >
> >          Herby i attach the patch for the Bug # 309869 with its
> > Changelog and the changelog of my previous patch for the bug # 301922
> >
> > On 7/12/05, Not Zed <notzed ximian com> wrote:
> >
> >
> >         Another strange bug.
> >
> >         I dont think you should be doing any strcmp stuff - for
> >         starters the
> >         text might be translated, i dont know where it is
> >         translated.  Compare
> >         the widget pointers instead.
> >
> >         On Tue, 2005-07-12 at 17:11 +0530, Antony Vincent Pandian
> >         wrote:
> >         >
> >         > Hi,
> >         >
> >         >      I have attached the patch for the bug # 309869.
> >         >
> >         >      This patch changes the focus to the corresponding
> >         headers' entry
> >         > fields.
> >         >
> >         >       The gtk_widget_grab_focus() is added in the functions
> >         where the
> >         > buttons (headers') click event is handled.
> >         >
> >         > --
> >         > S.Antony Vincent Pandian
> >         > _______________________________________________
> >         > evolution-patches mailing list
> >         > evolution-patches lists ximian com
> >         > http://lists.ximian.com/mailman/listinfo/evolution-patches
> >
> >
> >
> >
> > --
> > Luv,
> > S.Antony Vincent Pandian
> > _______________________________________________
> > evolution-patches mailing list
> > evolution-patches lists ximian com
> > http://lists.ximian.com/mailman/listinfo/evolution-patches
>
> _______________________________________________
> evolution-patches mailing list
> evolution-patches lists ximian com
> http://lists.ximian.com/mailman/listinfo/evolution-patches

-- 
Luv,
S.Antony Vincent Pandian
--- e-msg-composer-hdrs-bkp.c	2005-07-13 12:21:21.000000000 +0530
+++ e-msg-composer-hdrs.c	2005-07-13 14:14:11.000000000 +0530
@@ -186,6 +186,13 @@ address_button_clicked_cb (GtkButton *bu
 	emchas = data;
 	hdrs = emchas->hdrs;
 	priv = hdrs->priv;
+	
+	if(button == hdrs->priv->to.label)
+		gtk_widget_grab_focus(hdrs->priv->to.entry);
+	else if(button == priv->cc.label)
+		gtk_widget_grab_focus(hdrs->priv->cc.entry);
+	else if(button == priv->bcc.label)
+		gtk_widget_grab_focus(hdrs->priv->bcc.entry);
 
 	name_selector_dialog = e_name_selector_peek_dialog (priv->name_selector);
 	gtk_widget_show (GTK_WIDGET (name_selector_dialog));
@@ -516,6 +523,8 @@ post_browser_clicked_cb (GtkButton *butt
 	GtkWidget *dialog;
 	GList *post_items;
 
+	gtk_widget_grab_focus(hdrs->priv->post_to.entry);
+
 	model = mail_component_peek_tree_model (mail_component_peek ());
 	emft = (EMFolderTree *) em_folder_tree_new_with_model (model);
 	em_folder_tree_set_multiselect (emft, TRUE);

Attachment: ChangeLog
Description: Binary data